tt-rss: update feed-icons handling#371761
Conversation
56292a4 to
b53ed5a
Compare
|
This was originally missing the important half of the changes, apologies. Ready for review now |
b53ed5a to
ff12a00
Compare
|
@NixOS/nixpkgs-merge-bot merge |
ff12a00 to
8997145
Compare
|
Probably(?) caused by 7d30c40 I just rebased this, please try again :) |
|
Hi @fridtjof, I had low expectations for it to accept merging. But now with the explanation, I'm sure it won't be merged, as this auto-merge is limited to packages, not modules. We'll have to wait for a maintainer. |
This was changed over to go through the same cache system as everything else in 2022 [1]. Some clients still try to access them the old way, so I've added a compatibility rewrite. [1] https://community.tt-rss.org/t/favicons-cache-implementation-overhaul/5698
8997145 to
fa3b48f
Compare
|
Just bumped this and discovered an issue with the config as currently generated. |
This does not exist anymore as of at least 0-unstable-2025-04-17
|
Ugh okay, I figured it out. As of the current version of tt-rss used (0-unstable-2025-04-17), TTRSS_ICONS_DIR is still used, but exclusively for migrating old feed icons to the new directory. As of May 22nd, this migration code is no longer there: https://gitlab.tt-rss.org/tt-rss/tt-rss/-/commit/25d86552149830235a7f3908fa17fdb9d0b0dc5f I'll re-add the tmpfiles entry and add a comment as to why it's left in there. Would this break for NixOS users if tt-rss was bumped up beyond May 22nd inbetween releases? |
fa3b48f to
1d27d0a
Compare
|
In light of TT-RSS's sunset [1] and learning about the maintainer's general attitude (to put it lightly) I am no longer interested in fixing this. [1] https://community.tt-rss.org/t/the-end-of-tt-rss-org/7164/2 |
This was changed to go through the same cache system as everything else in 2022 [1]. Some clients still try to access the icons directly, so I've added a compatibility rewrite.
[1] https://community.tt-rss.org/t/favicons-cache-implementation-overhaul/5698
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.