Skip to content

Comments

tt-rss: update feed-icons handling#371761

Closed
fridtjof wants to merge 3 commits intoNixOS:masterfrom
fridtjof:ttrss-fix-feed-icons
Closed

tt-rss: update feed-icons handling#371761
fridtjof wants to merge 3 commits intoNixOS:masterfrom
fridtjof:ttrss-fix-feed-icons

Conversation

@fridtjof
Copy link
Contributor

@fridtjof fridtjof commented Jan 7, 2025

This was changed to go through the same cache system as everything else in 2022 [1]. Some clients still try to access the icons directly, so I've added a compatibility rewrite.

[1] https://community.tt-rss.org/t/favicons-cache-implementation-overhaul/5698

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 7, 2025
@fridtjof fridtjof force-pushed the ttrss-fix-feed-icons branch from 56292a4 to b53ed5a Compare January 30, 2025 17:25
@fridtjof
Copy link
Contributor Author

This was originally missing the important half of the changes, apologies. Ready for review now

@fridtjof fridtjof force-pushed the ttrss-fix-feed-icons branch from b53ed5a to ff12a00 Compare February 27, 2025 10:57
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 28, 2025
@gileri
Copy link
Contributor

gileri commented Mar 27, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@gileri merge not permitted (#305350):
nixos/modules/services/web-apps/tt-rss.nix is not in pkgs/by-name/

@fridtjof fridtjof force-pushed the ttrss-fix-feed-icons branch from ff12a00 to 8997145 Compare March 28, 2025 00:49
@fridtjof
Copy link
Contributor Author

Probably(?) caused by 7d30c40

I just rebased this, please try again :)

@gileri
Copy link
Contributor

gileri commented Mar 30, 2025

Hi @fridtjof, I had low expectations for it to accept merging. But now with the explanation, I'm sure it won't be merged, as this auto-merge is limited to packages, not modules. We'll have to wait for a maintainer.

This was changed over to go through the same cache system as everything else in 2022 [1].
Some clients still try to access them the old way, so I've added a compatibility rewrite.

[1] https://community.tt-rss.org/t/favicons-cache-implementation-overhaul/5698
@fridtjof fridtjof force-pushed the ttrss-fix-feed-icons branch from 8997145 to fa3b48f Compare August 2, 2025 11:40
@fridtjof
Copy link
Contributor Author

fridtjof commented Aug 2, 2025

Just bumped this and discovered an issue with the config as currently generated.

@fridtjof fridtjof marked this pull request as draft August 2, 2025 14:30
This does not exist anymore as of at least 0-unstable-2025-04-17
@fridtjof
Copy link
Contributor Author

fridtjof commented Aug 3, 2025

Ugh okay, I figured it out.

As of the current version of tt-rss used (0-unstable-2025-04-17), TTRSS_ICONS_DIR is still used, but exclusively for migrating old feed icons to the new directory.

As of May 22nd, this migration code is no longer there: https://gitlab.tt-rss.org/tt-rss/tt-rss/-/commit/25d86552149830235a7f3908fa17fdb9d0b0dc5f

I'll re-add the tmpfiles entry and add a comment as to why it's left in there.
However, I'm not familiar with how migrations like this are handled in relation to NixOS's release schedule, backporting practices and upgrade support.

Would this break for NixOS users if tt-rss was bumped up beyond May 22nd inbetween releases?

@fridtjof fridtjof force-pushed the ttrss-fix-feed-icons branch from fa3b48f to 1d27d0a Compare August 3, 2025 23:17
@fridtjof
Copy link
Contributor Author

fridtjof commented Oct 5, 2025

In light of TT-RSS's sunset [1] and learning about the maintainer's general attitude (to put it lightly) I am no longer interested in fixing this.

[1] https://community.tt-rss.org/t/the-end-of-tt-rss-org/7164/2

@fridtjof fridtjof closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants