yubikey-manager-qt: fix detecting inserted yubikey and mark as insecure#372205
Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom Mar 23, 2025
Merged
yubikey-manager-qt: fix detecting inserted yubikey and mark as insecure#372205SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
avdv
added
the
11.by: package-maintainer
Disasm
reviewed
Jan 10, 2025
13 tasks
Member
|
This appears to be unnecessary, as it seems to currently be working. |
Member
Author
Which revision did you test? It definitely does not work for me without a patch. I tried 121aa11. |
avdv
force-pushed
the
yubikey-manager-fix
branch
from
937f91d to
6957e57
Compare
avdv
changed the title
avdv
force-pushed
the
yubikey-manager-fix
branch
from
b68b064 to
5aa63e0
Compare
Member
|
I'm not sure what I did back then. I've since installed the flutter version and removed the original yubikey manager. I assume you have the more up-to-date info |
Member
|
We might as well drop it at this point as it is now broken for a few months and unmaintained. |
Member
|
Agreed, but we should at least merge this PR. |
github-actions
bot
added
the
10.rebuild-linux: 1
Fixes NixOS#353582 The upload functionality was removed in an upstream dependency, so importing the types failed and caused an error. See Yubico/yubikey-manager-qt#364 (comment)
The project is not under development anymore, Yubico Authenticator is recommended instead.
SuperSandro2000
force-pushed
the
yubikey-manager-fix
branch
from
f553241 to
7f4cb6e
Compare
SuperSandro2000
changed the title
SuperSandro2000
approved these changes
Mar 23, 2025
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Testing this from nixpkgs is not enough, you need to rebuild your system with it andt hen it works
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353582
The upload functionality was removed in an upstream dependency, so importing the types failed and caused an error.
See Yubico/yubikey-manager-qt#364 (comment)
Also, let's mark it as insecure as suggested by @Pandapip1 since it is no longer actively developed / maintained.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.