doc: Cross-reference roles syntax doc & implementation#374035
doc: Cross-reference roles syntax doc & implementation#374035FliegendeWurst merged 1 commit intoNixOS:masterfrom
Conversation
reasoning:
- (doc -> code) make it easier to find where those are implemented
- to get easier insight if/what a specific renderer does with it
- in case one wants to improve them, which seems likely
as they are rather Nix/NixOS-specific
- (took me too long to find their implementation)
- (code -> doc) ensure changes to the code can be reflected in the doc
- code authors might not know about the reference documentation
or how to find it
|
If someone of you knows more about this (non-blocking): This line of the AsciiDoc renderer looks like a wildcard for some roles: https://github.com/Zocker1999NET/nixpkgs/blob/3c20746f99537b0c8bf42ceef162fe73cdef7c77/pkgs/by-name/ni/nixos-render-docs/src/nixos_render_docs/asciidoc.py#L190 But I have not found if this is there to use AsciiDoc native roles (& where those are documented) or if there is some CSS file or so where those are handled. In case this is not native, I think referencing |
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Looks good, at least not wrong - I'm not an expert on this code.
Not exactly sure, but the long term correct way to do this may be some sort of auto generation of docs, but that would likely require tearing apart all of the code.
reasoning:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.