Skip to content

Conversation

@niklaskorz
Copy link
Contributor

@niklaskorz niklaskorz commented Jan 17, 2025

As there seems to be a consensus of keeping buildRustCrate and defaultCrateOverrides in-tree, we should work on getting defaultCrateOverrides up to date.

This PR removes obsolete darwin overrides that were required before the big refactoring of macOS SDKs in nixpkgs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 17, 2025
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jan 17, 2025
@nix-owners nix-owners bot requested review from figsoda, winterqt and zowoq January 17, 2025 00:58
@niklaskorz niklaskorz requested review from Kranzes and flokli January 17, 2025 01:00
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 17, 2025
@emilazy
Copy link
Member

emilazy commented Jan 17, 2025

Let’s avoid the manual formatting; it’ll mean screwing up git blame for this large file or else another entry in .git-blame-ignore-revs. The final treewide format should come soon enough.

@niklaskorz niklaskorz force-pushed the defaultcrateoverrides-darwin branch from 4932760 to 514d472 Compare January 17, 2025 01:49
@flokli flokli merged commit 8956e27 into NixOS:master Jan 21, 2025
25 of 27 checks passed
@niklaskorz niklaskorz deleted the defaultcrateoverrides-darwin branch January 22, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants