Skip to content

Conversation

@numinit
Copy link
Contributor

@numinit numinit commented Jan 19, 2025

Remove things that take forever to compile and seem to benchmark GCC when no one depends on them.

  • fstar now maintains copies of z3 that simply override what nixpkgs tracks
  • solc works with the latest as well

These take a long time to compile and were accruing lots of patches. After nixpkgs 25.05, we should drop them.

Move to by-name while we're at it; it fits nicely. :-)


Depends-on: #374917
Depends-on: #374928

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@numinit numinit force-pushed the z3/remove-all-but-latest branch from 4f7539f to e856410 Compare April 21, 2025 07:36
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 21, 2025
@numinit numinit force-pushed the z3/remove-all-but-latest branch from e856410 to d963c79 Compare April 21, 2025 07:39
@numinit numinit changed the title z3: drop all but 4.13.x z3: drop all but 4.14.x Apr 21, 2025
@numinit numinit force-pushed the z3/remove-all-but-latest branch from d963c79 to 757c264 Compare April 21, 2025 07:42
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Apr 21, 2025
@numinit numinit marked this pull request as ready for review April 21, 2025 07:43
@numinit numinit force-pushed the z3/remove-all-but-latest branch from 757c264 to 3753156 Compare April 21, 2025 07:44
@nix-owners nix-owners bot requested a review from natsukium April 21, 2025 07:44
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pname change was causing a bunch of unnecessary rebuilds.

numinit added 2 commits April 21, 2025 00:51
Clean up this package set, since nothing depends on it now, and
deal-solver now appears to work fine.
@numinit numinit force-pushed the z3/remove-all-but-latest branch from 3753156 to 6309e4e Compare April 21, 2025 07:51
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 21, 2025
@nix-owners nix-owners bot requested a review from ttuegel April 21, 2025 07:52
@numinit
Copy link
Contributor Author

numinit commented Apr 21, 2025

⚠️ Warning: this build uses a ton of RAM ⚠️

128 GB was insufficient to run nixpkgs-review on a 24 core EPYC 4 with the standard job count and parallelism. Beware!

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374929


x86_64-linux

⏩ 10 packages marked as broken and skipped:
  • python312Packages.cynthion
  • python312Packages.cynthion.dist
  • python312Packages.luna-soc
  • python312Packages.luna-soc.dist
  • python312Packages.luna-usb
  • python312Packages.luna-usb.dist
  • python313Packages.luna-soc
  • python313Packages.luna-soc.dist
  • python313Packages.luna-usb
  • python313Packages.luna-usb.dist
❌ 5 packages failed to build:
  • glasgow
  • glasgow.dist
  • pony-corral
  • ponyc
  • ugarit
✅ 84 packages built:
  • acl2
  • alive2
  • circt
  • circt.dev
  • circt.lib
  • cynthion
  • cynthion.dist
  • dafny
  • foundry
  • fstar
  • ghidra-extensions.kaiju
  • hal-hardware-analyzer
  • iprover
  • isabelle
  • isabelle-components.isabelle-linter
  • key
  • klee
  • libbap
  • nb
  • nixpkgs-manual
  • ocamlPackages.z3
  • python312Packages.amaranth
  • python312Packages.amaranth-boards
  • python312Packages.amaranth-boards.dist
  • python312Packages.amaranth-soc
  • python312Packages.amaranth-soc.dist
  • python312Packages.amaranth.dist
  • python312Packages.angr
  • python312Packages.angr.dist
  • python312Packages.angrcli
  • python312Packages.angrcli.dist
  • python312Packages.angrop
  • python312Packages.angrop.dist
  • python312Packages.bap
  • python312Packages.bap.dist
  • python312Packages.claripy
  • python312Packages.claripy.dist
  • python312Packages.deal
  • python312Packages.deal-solver
  • python312Packages.deal-solver.dist
  • python312Packages.deal.dist
  • python312Packages.icontract
  • python312Packages.icontract.dist
  • python312Packages.miasm
  • python312Packages.miasm.dist
  • python312Packages.model-checker
  • python312Packages.model-checker.dist
  • python312Packages.pylddwrap
  • python312Packages.pylddwrap.dist
  • z3.python (python312Packages.z3-solver ,z3_4_14.python)
  • python313Packages.amaranth
  • python313Packages.amaranth-boards
  • python313Packages.amaranth-boards.dist
  • python313Packages.amaranth-soc
  • python313Packages.amaranth-soc.dist
  • python313Packages.amaranth.dist
  • python313Packages.bap
  • python313Packages.bap.dist
  • python313Packages.claripy
  • python313Packages.claripy.dist
  • python313Packages.deal
  • python313Packages.deal-solver
  • python313Packages.deal-solver.dist
  • python313Packages.deal.dist
  • python313Packages.icontract
  • python313Packages.icontract.dist
  • python313Packages.model-checker
  • python313Packages.model-checker.dist
  • python313Packages.pylddwrap
  • python313Packages.pylddwrap.dist
  • python313Packages.z3-solver (python313Packages.z3-solver.dev ,python313Packages.z3-solver.lib ,python313Packages.z3-solver.python)
  • ruff-lsp
  • ruff-lsp.dist
  • sail-riscv
  • sby
  • simbaplusplus
  • solc
  • symcc
  • tlaps
  • vampire
  • z3 (z3_4_14)
  • z3-tptp
  • z3.dev (z3_4_14.dev)
  • z3.lib (z3_4_14.lib)

ponyc is being fixed in #396553. Other failures look unrelated.

@RossComputerGuy
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374929


aarch64-linux

⏩ 12 packages marked as broken and skipped:
  • boogie
  • dotnetPackages.Boogie
  • python312Packages.cynthion
  • python312Packages.cynthion.dist
  • python312Packages.luna-soc
  • python312Packages.luna-soc.dist
  • python312Packages.luna-usb
  • python312Packages.luna-usb.dist
  • python313Packages.luna-soc
  • python313Packages.luna-soc.dist
  • python313Packages.luna-usb
  • python313Packages.luna-usb.dist
⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
❌ 4 packages failed to build:
  • acl2
  • pony-corral
  • ponyc
  • ugarit
✅ 87 packages built:
  • alive2
  • circt
  • circt.dev
  • circt.lib
  • cynthion
  • cynthion.dist
  • dafny
  • foundry
  • fstar
  • ghidra-extensions.kaiju
  • glasgow
  • glasgow.dist
  • hal-hardware-analyzer
  • haskellPackages.hz3
  • haskellPackages.hz3.doc
  • haskellPackages.rest-rewrite
  • haskellPackages.smtlib-backends-z3
  • haskellPackages.smtlib-backends-z3.doc
  • haskellPackages.z3
  • haskellPackages.z3.doc
  • iprover
  • isabelle
  • isabelle-components.isabelle-linter
  • key
  • libbap
  • nixpkgs-manual
  • python312Packages.amaranth
  • python312Packages.amaranth-boards
  • python312Packages.amaranth-boards.dist
  • python312Packages.amaranth-soc
  • python312Packages.amaranth-soc.dist
  • python312Packages.amaranth.dist
  • python312Packages.angr
  • python312Packages.angr.dist
  • python312Packages.angrcli
  • python312Packages.angrcli.dist
  • python312Packages.angrop
  • python312Packages.angrop.dist
  • python312Packages.bap
  • python312Packages.bap.dist
  • python312Packages.claripy
  • python312Packages.claripy.dist
  • python312Packages.deal
  • python312Packages.deal-solver
  • python312Packages.deal-solver.dist
  • python312Packages.deal.dist
  • python312Packages.icontract
  • python312Packages.icontract.dist
  • python312Packages.miasm
  • python312Packages.miasm.dist
  • python312Packages.model-checker
  • python312Packages.model-checker.dist
  • python312Packages.pylddwrap
  • python312Packages.pylddwrap.dist
  • z3.python (python312Packages.z3-solver, z3_4_14.python)
  • python313Packages.amaranth
  • python313Packages.amaranth-boards
  • python313Packages.amaranth-boards.dist
  • python313Packages.amaranth-soc
  • python313Packages.amaranth-soc.dist
  • python313Packages.amaranth.dist
  • python313Packages.bap
  • python313Packages.bap.dist
  • python313Packages.claripy
  • python313Packages.claripy.dist
  • python313Packages.deal
  • python313Packages.deal-solver
  • python313Packages.deal-solver.dist
  • python313Packages.deal.dist
  • python313Packages.icontract
  • python313Packages.icontract.dist
  • python313Packages.model-checker
  • python313Packages.model-checker.dist
  • python313Packages.pylddwrap
  • python313Packages.pylddwrap.dist
  • python313Packages.z3-solver (python313Packages.z3-solver.dev, python313Packages.z3-solver.lib, python313Packages.z3-solver.python)
  • sail-riscv
  • sby
  • simbaplusplus
  • solc
  • symcc
  • tlaps
  • vampire
  • z3 (z3_4_14)
  • z3-tptp
  • z3.dev (z3_4_14.dev)
  • z3.lib (z3_4_14.lib)

@numinit numinit merged commit 8cd7807 into NixOS:master Apr 23, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants