slade: 3.2.6 -> 3.2.7

[Nobody-alias-N]

Resolves #394467

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Nobody-alias-N]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375215

---

x86_64-linux

✅ 1 package built:

• slade

[Nobody-alias-N]

As a reminder, it has an insecure dependency: freeimage

[polygon]

Builds and works. Approved.

[Nobody-alias-N]

No longer works!
The log:

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/l470rjcpwgg171bs7wmxfq41z8ard6zn-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/fhc99xiwi018cqigflfnd76p05mjkg22-slade-3.2.7/share/loca>
-- The C compiler identification is GNU 14.2.1
-- The CXX compiler identification is GNU 14.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/8v6k283dpbc0qkdq81nb6mrxrgcb10i1-gcc-wrapper-14-20241116/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/8v6k283dpbc0qkdq81nb6mrxrgcb10i1-gcc-wrapper-14-20241116/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- wx-config used is: /nix/store/46rwb13dcgl0z2ql07xbjzp2rmjrply0-wxwidgets-3.2.6/bin/wx-config
-- wxWidgets version is: 3.2.6
-- gtk version is: 3
-- Found wxWidgets: -L/nix/store/46rwb13dcgl0z2ql07xbjzp2rmjrply0-wxwidgets-3.2.6/lib;-pthread;;;-L/nix/store/ylzpk54f82kc888pr4325ynshk48la6i-libglvnd-1.7.0/lib;-L/nix/store/q6063jl4mgbz9fk8hnfy1l5m8y9vldl5-glu-9.0.3/lib;-lwx_gtk3u_aui-3.2;-lwx_gtk3u_gl-3.2;-lwx_gtk3u_stc>
CMake Error at /nix/store/gyn8zrrgzk3h47izzlym76vqz0q2ymvd-sfml-3.0.0/lib/cmake/SFML/SFMLConfig.cmake:182 (message):
  Requested SFML configuration (Shared) was not found
Call Stack (most recent call first):
  cmake/unix.cmake:82 (find_package)
  src/CMakeLists.txt:42 (include)
CMake Error at cmake/unix.cmake:82 (find_package):
  Found package configuration file:
    /nix/store/gyn8zrrgzk3h47izzlym76vqz0q2ymvd-sfml-3.0.0/lib/cmake/SFML/SFMLConfig.cmake
  but it set SFML_FOUND to FALSE so package "SFML" is considered to be NOT
  FOUND.
Call Stack (most recent call first):
  src/CMakeLists.txt:42 (include)
-- Configuring incomplete, errors occurred!

[FraGag]

This new issue with SFML is related to #394467.

#387764 recently updated sfml from 2.x to 3.x, which introduced breaking changes. SLADE 3.2.7 added support for SFML 3.x, but sfml is built as a set of static libraries instead of shared libraries (while sfml_2 is built as shared libraries), and SLADE is apparently looking for shared libraries for SFML.

The fact that SFML 3.x defaults to static libraries is an upstream change (compare https://github.com/SFML/SFML/blob/2.6.2/CMakeLists.txt#L47-L51 with https://github.com/SFML/SFML/blob/3.0.0/CMakeLists.txt#L45-L47). Perhaps BUILD_SHARED_LIBS should be set to ON in sfml.

As a workaround, SLADE's derivation could be changed to use sfml_2 instead of sfml.

[Nobody-alias-N]

@FraGag
Thank you so much for those details!
Also, thank you for the workaround.

[polygon]

Builds and works (when insecure package freeimage is allowed), approved.

[dimkauzh]

Works, when will it be merged?