eb-garamond: add TTF and WOFF #375307
Merged
eb-garamond: add TTF and WOFF #375307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklaskorz
requested changes
Jan 20, 2025
Contributor
There was a problem hiding this comment.
Please make sure all commits are formatted using nixfmt-rfc-style as stated in CONTRIBUTING.md:
New files must be formatted by entering the nix-shell from the repository root and running nixfmt.
(not a new file in this case, but a previously already formatted file, hence the failing GA check)
NixOSInfra
added
the
12.first-time contribution
github-actions
bot
added
10.rebuild-darwin: 1-10
niklaskorz
requested changes
Jan 20, 2025
bengsparks
force-pushed
the
eb-garamond-from-source
branch
2 times, most recently
from
477220d to
c762189
Compare
niklaskorz
reviewed
Jan 20, 2025
Contributor
|
Contributor
error: build of '/nix/store/k3fsx9df8jkb93s2awsbh2fvvnlwrg54-source.drv' on 'ssh-ng://rosetta-builder' failed: hash mismatch in fixed-output derivation '/nix/store/k3fsx9df8jkb93s2awsbh2fvvnlwrg54-source.drv':
specified: sha256-3eByiJ0gVpKXtKP8AH0P9G5vTbdvkmnfD4Dn2JQ7K54=
got: sha256-ajieKhTeH6yv2qiE2xqnHFoMS65//4ZKiccAlC2PXGQ= |
bengsparks
force-pushed
the
eb-garamond-from-source
branch
from
c762189 to
1d95ce0
Compare
github-actions
bot
added
10.rebuild-darwin: 1
niklaskorz
reviewed
Jan 20, 2025
drupol
requested changes
Jan 20, 2025
bengsparks
force-pushed
the
eb-garamond-from-source
branch
from
1d95ce0 to
a4d19e7
Compare
drupol
approved these changes
Jan 21, 2025
Contributor
Author
|
Contributor
|
niklaskorz
approved these changes
Jan 21, 2025
github-actions
bot
added
the
8.has: maintainer-list (update)
drupol
approved these changes
Jan 21, 2025
bengsparks
force-pushed
the
eb-garamond-from-source
branch
from
1cf4619 to
ad97732
Compare
drupol
requested changes
Jan 21, 2025
Contributor
drupol
left a comment
drupol
left a comment
There was a problem hiding this comment.
trace: maintainer bengsparks (line 2845) should be listed after benesim, not after benhiemer (line 2795)
Contributor
|
Please change the commit message from |
bengsparks
force-pushed
the
eb-garamond-from-source
branch
from
ad97732 to
e031d66
Compare
niklaskorz
approved these changes
Jan 21, 2025
drupol
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EB Garamond is currently made available by installing OTF files to the correct location.
By building the font from source using the GitHub repository instead of the bitbucket archive, the TTF and WOFF files also become available for installation.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.