Skip to content

cmake: set CMAKE_BUILD_PARALLEL_LEVEL #377192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
K900 merged 2 commits into from
Feb 9, 2025
Merged

cmake: set CMAKE_BUILD_PARALLEL_LEVEL #377192

K900 merged 2 commits into from
Feb 9, 2025

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Jan 27, 2025 •
edited
Loading

https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html

inspired by and closes #377188

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 27, 2025
@nix-owners nix-owners bot requested a review from veprbl January 27, 2025 02:37
@kirillrdy kirillrdy mentioned this pull request Jan 27, 2025
Merged
13 tasks
@pbsds pbsds marked this pull request as ready for review January 28, 2025 07:27
tobim
tobim approved these changes Feb 4, 2025
View reviewed changes
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 4, 2025
@pbsds pbsds force-pushed the feat-cmake-build-cores-1737943833 branch from 6995cea to 5d3a18a Compare February 5, 2025 12:12
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 5, 2025
@K900 K900 merged commit ec10d5f into NixOS:staging Feb 9, 2025
27 checks passed
@kirillrdy kirillrdy mentioned this pull request Feb 23, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl Awaiting requested review from veprbl

1 more reviewer

@tobim tobim tobim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbsds @tobim @K900 @wegank