bundler: 2.5.22 -> 2.6.2#377415
Merged
GaetanLepage merged 25 commits intoNixOS:masterfrom Mar 13, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
|
Member
|
this breaks something like this will do #356159 |
Contributor
blocking updates is IMHO not the way to go, you should resolve the root cause in gitlab code: #353632 (comment) |
liberodark
force-pushed
the
bundler
branch
2 times, most recently
from
9ce24a7 to
d32237d
Compare
Member
it is preferred to fix the root cause, but unti that is done, breaking changes will block updates, otherwise they get reverted again
we can/should add |
Contributor
@kirillrdy |
Member
the root cause is known, bundler writes it's version into Gemfile.lock, and if version mismatches it refuses to proceed there is no easy solution here, since that check in bundler exists for a good reason. updating them in tandem is not hard, or we can make gitlab bundle own version of bundler. marking gitlab as broken is also not an option. maybe @yayayayaka can suggest something |
kirillrdy
reviewed
Feb 15, 2025
Member
kirillrdy
left a comment
kirillrdy
left a comment
There was a problem hiding this comment.
doesn't build
> Running phase: fixupPhase
> shrinking RPATHs of ELF executables and libraries in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2
> checking for references to /build/ in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2...
> gzipping man pages under /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/share/man/
> stripping (with command strip and flags -S -p) in /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/lib /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/bin
> rewriting symlink /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2/nix-support/gem-meta/spec to be relative to /nix/store/hba672kq269jwsfrbliq5ckj6jd2w3qs-bundler-2.6.2
> Running phase: installCheckPhase
> Executing versionCheckPhase
> both $pname and $versionCheckProgram are empty, so we don't know which program to run the versionCheckPhase upon
For full logs, run 'nix log /nix/store/c1aknjglajkpa7j9n5kv40x84grnkql7-bundler-2.6.2.drv'.
Member
|
potential fix for gitlab #382196 |
Contributor
|
thank you @kirillrdy |
Contributor
|
@liberodark regarding the mentioned build failure, why did you change to nix-update-script? Apparently the old script logic still works? |
GaetanLepage
requested changes
Feb 16, 2025
liberodark
force-pushed
the
bundler
branch
2 times, most recently
from
e8fb80c to
58a6562
Compare
GaetanLepage
approved these changes
Mar 2, 2025
Contributor
|
cc @anthonyroussel as you are the maintainer of this package. |
liberodark
force-pushed
the
bundler
branch
2 times, most recently
from
054a508 to
c52d71b
Compare
Contributor
|
Member
|
I need this for a mastodon update and going to clean out the outstanding regresions (turns out most of them are pre-existing and caused by outdated lock files) and push them onto the PR. |
SuperSandro2000
force-pushed
the
bundler
branch
from
811207c to
e43fedd
Compare
github-actions
bot
added
the
6.topic: ruby
Member
|
Can we merge this? |
Member
|
no objections from me |
kirillrdy
approved these changes
Mar 12, 2025
wegank
added
the
12.approvals: 2
Contributor
|
@GaetanLepage @liberodark thx! bundler 2.6.6 is available, we should see a bump PR right, at least I dont find one? |
Member
|
#390068 draft for now |
13 tasks
Contributor
|
This PR marks astroid as broken, however, #387722 fixes the referenced build error. Can we revert that commit? |
Member
|
Please open a PR for that and re-test if that still is true. |
Contributor
Done, please see #392429 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix : #372606
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.