-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
vimPlugins.sonarlint-nvim: init at 0-unstable-2025-04-18 #377720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d09f33 to
0a56c30
Compare
PerchunPak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, all new non-github plugins should go to pkgs/applications/editors/vim/plugins/non-generated (#376366)
|
In the end I figured out the issue with this plugin https://gitlab.com/schrieveslaach/sonarlint.nvim/-/issues/29 I already created an issue in the repo of the author |
9559712 to
42bf6e3
Compare
99c0081 to
eb15511
Compare
PerchunPak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, look at other plugins at non-generated folder and base this plugin on them
Right now, it lacks passthru.updateScript, proper version, meta.description and others, etc
I'm not really sure what version to put since on GitLab this plugin doesn't have releases, so I'm just putting today's date as I have seen other plugins doing the same. Also should I add myself as mantainer? |
pkgs/applications/editors/vim/plugins/non-generated/sonarlint-nvim/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/vim/plugins/non-generated/sonarlint-nvim/default.nix
Outdated
Show resolved
Hide resolved
|
GaetanLepage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you squash your commits?
1a5f240 to
b5d3f77
Compare
Squashed, I've also added |
Oh yes good shot! |
Yes, that would be great. |
b5d3f77 to
85c18af
Compare
Done |
pkgs/applications/editors/vim/plugins/non-generated/sonarlint-nvim/default.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/editors/vim/plugins/non-generated/sonarlint-nvim/default.nix
Outdated
Show resolved
Hide resolved
c1ef0d2 to
414a2e6
Compare
414a2e6 to
ad25dc4
Compare
fd57d37 to
e8d0dba
Compare
|
GaetanLepage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!

This PR aims to add sonarlint.nvim to official repos.
Still testing because it doesn't work on my machine yet, I just managed to make it launch but I'm not receiving any linting for TypeScript
Things done
nix run .#vimPluginsUpdater -- add "https://gitlab.com/schrieveslaach/sonarlint.nvim"nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.