Skip to content

Conversation

@c3n21
Copy link
Contributor

@c3n21 c3n21 commented Jan 29, 2025

This PR aims to add sonarlint.nvim to official repos.

Still testing because it doesn't work on my machine yet, I just managed to make it launch but I'm not receiving any linting for TypeScript

Things done

nix run .#vimPluginsUpdater -- add "https://gitlab.com/schrieveslaach/sonarlint.nvim"
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: vim Advanced text editor label Jan 29, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 29, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from 3d09f33 to 0a56c30 Compare February 2, 2025 09:38
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, all new non-github plugins should go to pkgs/applications/editors/vim/plugins/non-generated (#376366)

@c3n21
Copy link
Contributor Author

c3n21 commented Feb 2, 2025

image
Even passing nodejs explicitly as runtimeDeps it still gives me this error (to see that you should add this handler in your NeoVim config)

vim.lsp.handlers['sonarlint/canShowMissingRequirementsNotification'] = function()
    return true
end

I will try to run NeoVim in a Ubuntu VM to see if it's something strictly related to how Nix builds NeoVim

@c3n21
Copy link
Contributor Author

c3n21 commented Feb 8, 2025

In the end I figured out the issue with this plugin

https://gitlab.com/schrieveslaach/sonarlint.nvim/-/issues/29

I already created an issue in the repo of the author

@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch 2 times, most recently from 9559712 to 42bf6e3 Compare February 8, 2025 11:23
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 2, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from 99c0081 to eb15511 Compare April 20, 2025 16:41
@c3n21 c3n21 marked this pull request as ready for review April 20, 2025 16:41
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 20, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 20, 2025
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, look at other plugins at non-generated folder and base this plugin on them

Right now, it lacks passthru.updateScript, proper version, meta.description and others, etc

@c3n21
Copy link
Contributor Author

c3n21 commented Apr 20, 2025

Please, look at other plugins at non-generated folder and base this plugin on them

Right now, it lacks passthru.updateScript, proper version, meta.description and others, etc

I'm not really sure what version to put since on GitLab this plugin doesn't have releases, so I'm just putting today's date as I have seen other plugins doing the same.

Also should I add myself as mantainer?

@aciceri
Copy link
Member

aciceri commented Apr 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377720


x86_64-linux

✅ 1 package built:
  • vimPlugins.sonarlint-nvim

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you squash your commits?

@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from 1a5f240 to b5d3f77 Compare April 21, 2025 09:41
@c3n21
Copy link
Contributor Author

c3n21 commented Apr 21, 2025

Thanks, can you squash your commits?

Squashed, I've also added -unstable- in version as stated in the docs

@GaetanLepage
Copy link
Contributor

Squashed, I've also added -unstable- in version as stated in the docs

Oh yes good shot!

@GaetanLepage
Copy link
Contributor

Also should I add myself as mantainer?

Yes, that would be great.

@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from b5d3f77 to 85c18af Compare April 21, 2025 10:17
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 21, 2025
@c3n21
Copy link
Contributor Author

c3n21 commented Apr 21, 2025

Also should I add myself as mantainer?

Yes, that would be great.

Done

@c3n21 c3n21 changed the title vimPlugins.sonarlint-nvim: init at 2025-01-24 vimPlugins.sonarlint-nvim: init at 0-unstable-2025-04-18 Apr 21, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from c1ef0d2 to 414a2e6 Compare April 21, 2025 13:42
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch from 414a2e6 to ad25dc4 Compare April 21, 2025 13:42
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Apr 21, 2025
@c3n21 c3n21 force-pushed the feature/sonarlint-nvim branch 2 times, most recently from fd57d37 to e8d0dba Compare April 21, 2025 14:12
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377720


x86_64-linux

✅ 1 package built:
  • vimPlugins.sonarlint-nvim

aarch64-linux

✅ 1 package built:
  • vimPlugins.sonarlint-nvim

x86_64-darwin

✅ 1 package built:
  • vimPlugins.sonarlint-nvim

aarch64-darwin

✅ 1 package built:
  • vimPlugins.sonarlint-nvim

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@GaetanLepage GaetanLepage requested a review from PerchunPak April 21, 2025 14:16
@GaetanLepage GaetanLepage merged commit e2b56be into NixOS:master Apr 21, 2025
49 of 52 checks passed
@c3n21 c3n21 deleted the feature/sonarlint-nvim branch April 21, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants