build-support/rust/sysroot: remove#378006
Merged
winterqt merged 1 commit intoNixOS:masterfrom Feb 1, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: rust
alyssais
force-pushed
the
rust-sysroot-remove
branch
from
39f0691 to
f7ad056
Compare
github-actions
bot
added
10.rebuild-darwin: 0
The sysroot derivation used by buildRustPackage hasn't built since c263e0b ("cargo,clippy,rustc,rustfmt: 1.81.0 -> 1.82.0"). That means that it's never built on 24.11, so there can't be anybody relying on it working on any supported version Nixpkgs. In the meantime, it's causing maintenance friction — I've spent a lot of time trying to figure out how to build it as part of the transition away from fetchCargoTarball, before realising that it doesn't work anyway and must be unused. It can come back in the future if somebody wants to maintain it.
alyssais
force-pushed
the
rust-sysroot-remove
branch
from
f7ad056 to
c8127fc
Compare
zowoq
approved these changes
Jan 30, 2025
wegank
added
12.approvals: 1
winterqt
approved these changes
Feb 1, 2025
Contributor
|
Could we backport this PR? This will make backporting #382550 much easier by eliminating the sysroot-related global assertion. |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-378006-to-release-24.11 origin/release-24.11
cd .worktree/backport-378006-to-release-24.11
git switch --create backport-378006-to-release-24.11
git cherry-pick -x c8127fc287c344b9578458e69c760e36d4284749 |
Member
Author
|
Would be willing to merge a manual backport. |
13 tasks
Contributor
It's now PR #391339. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sysroot derivation used by buildRustPackage hasn't built since c263e0b ("cargo,clippy,rustc,rustfmt: 1.81.0 -> 1.82.0"). That means that it's never built on 24.11, so there can't be anybody relying on it working on any supported version Nixpkgs. In the meantime, it's causing maintenance friction — I've spent a lot of time trying to figure out how to build it as part of the transition away from fetchCargoTarball, before realising that it doesn't work anyway and must be unused. It can come back in the future if somebody wants to maintain it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.