Skip to content

expressvpn: fix daemon not able to modify resolv.conf #379943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FliegendeWurst merged 3 commits into from
Mar 18, 2025
Merged

expressvpn: fix daemon not able to modify resolv.conf #379943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb9cabe
fix(expressvpn): daemon not able to modify resolv.conf
e2r2fx Feb 6, 2025
0d176e3
update expressvpndFHS wrapper pname
e2r2fx Mar 13, 2025
be9c0e7
remove unnecessary copying of hosts's resolv.conf
e2r2fx Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions pkgs/by-name/ex/expressvpn/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,21 @@ let
};

expressvpndFHS = buildFHSEnv {
inherit pname version;
inherit version;
pname = "expressvpnd";

# When connected, it directly creates/deletes resolv.conf to change the DNS entries.
# Since it's running in an FHS environment, it has no effect on actual resolv.conf.
# Hence, place a watcher that updates host resolv.conf when FHS resolv.conf changes.

# Mount the host's resolv.conf to the container's /etc/resolv.conf
runScript = writeScript "${pname}-wrapper" ''
cp /host/etc/resolv.conf /etc/resolv.conf;
mkdir -p /host/etc
[ -e /host/etc/resolv.conf ] || touch /host/etc/resolv.conf
mount --bind /etc/resolv.conf /host/etc/resolv.conf
mount -o remount,rw /host/etc/resolv.conf
trap "umount /host/etc/resolv.conf" EXIT

while inotifywait /etc 2>/dev/null;
do
cp /etc/resolv.conf /host/etc/resolv.conf;
Expand Down