Skip to content

Comments

treewide: migrate packages to pkgs/by-name, again#380695

Merged
jopejoe1 merged 2 commits intoNixOS:masterfrom
jopejoe1:move-to-by-name
Mar 25, 2025
Merged

treewide: migrate packages to pkgs/by-name, again#380695
jopejoe1 merged 2 commits intoNixOS:masterfrom
jopejoe1:move-to-by-name

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Feb 9, 2025

Re-ran the script written by @Aleksanaa used in #354531 to move some more packages that are now possible to move.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Aleksanaa
Copy link
Member

Could you force push to trigger CI again?

@jopejoe1
Copy link
Member Author

Could you force push to trigger CI again?

Done

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 10, 2025
@Aleksanaa
Copy link
Member

It looks fine, just having a conflict

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 17, 2025
@github-actions github-actions bot added the 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions label Mar 15, 2025
@nix-owners nix-owners bot requested review from infinisil and philiptaron March 15, 2025 11:00
@philiptaron
Copy link
Contributor

I think you might need to undo the change for gnumake: https://github.com/NixOS/nixpkgs/actions/runs/13872199134/job/38820227435?pr=380695

Other than that, LGTM.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 25, 2025
@jopejoe1 jopejoe1 merged commit 6ea2759 into NixOS:master Mar 25, 2025
23 of 27 checks passed
@jopejoe1 jopejoe1 deleted the move-to-by-name branch March 25, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants