Skip to content

Comments

zstd: 1.5.6 -> 1.5.7#383579

Merged
fpletz merged 1 commit intoNixOS:stagingfrom
trofi:zstd-update
Mar 18, 2025
Merged

zstd: 1.5.6 -> 1.5.7#383579
fpletz merged 1 commit intoNixOS:stagingfrom
trofi:zstd-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Feb 20, 2025

Changes: https://github.com/facebook/zstd/releases/tag/v1.5.7

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Feb 20, 2025
@NyCodeGHG
Copy link
Member

from the release notes:

man pages were not properly updated in this package, and are still pointing to v1.5.6 [...]

We should either apply this patch or build the man pages ourselves.

@trofi
Copy link
Contributor Author

trofi commented Feb 20, 2025

from the release notes:

man pages were not properly updated in this package, and are still pointing to v1.5.6 [...]

We should either apply this patch or build the man pages ourselves.

Sounds good. Applied as is.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5290

@fpletz fpletz merged commit 4769eec into NixOS:staging Mar 18, 2025
27 checks passed
@trofi trofi deleted the zstd-update branch March 18, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants