Skip to content

Comments

python3Packages.betterproto: fix build failure#383595

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pineapplehunter:betterproto/fix-build
Mar 20, 2025
Merged

python3Packages.betterproto: fix build failure#383595
pbsds merged 1 commit intoNixOS:masterfrom
pineapplehunter:betterproto/fix-build

Conversation

@pineapplehunter
Copy link
Contributor

@pineapplehunter pineapplehunter commented Feb 20, 2025

This PR fixes the build failure of python3Packages.betterproto and updates it to 2.0.0b7.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 20, 2025
@nix-owners nix-owners bot requested a review from nikstur February 20, 2025 08:30
@pineapplehunter
Copy link
Contributor Author

I think I missed a lot of the diff from 2.0.0b6 to 2.0.0b7, so I will change this PR to only fix the build failure.

@pineapplehunter pineapplehunter changed the title python3Packages.betterproto: 2.0.0b6 -> 2.0.0b7, fix build failure python3Packages.betterproto: fix build failure Feb 20, 2025
@pbsds pbsds merged commit 06c6b7f into NixOS:master Mar 20, 2025
43 checks passed
@dotlambda
Copy link
Member

I think #391072 is more maintainable.

@pbsds
Copy link
Member

pbsds commented Mar 20, 2025

I think #391072 is more maintainable.

I fully agree, #391698

@pineapplehunter pineapplehunter deleted the betterproto/fix-build branch March 31, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants