Skip to content

Comments

icu77: init at 77.1#384638

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
afh:init-icu77-rc1
Mar 22, 2025
Merged

icu77: init at 77.1#384638
7c6f434c merged 1 commit intoNixOS:masterfrom
afh:init-icu77-rc1

Conversation

@afh
Copy link
Member

@afh afh commented Feb 24, 2025

https://github.com/unicode-org/icu/releases/tag/release-77-rc

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@afh afh marked this pull request as draft February 24, 2025 00:28
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 24, 2025
@afh afh changed the title icu77: init at 77.1rc icu77: init at 77.1 Mar 13, 2025
@afh afh force-pushed the init-icu77-rc1 branch from 5bfe258 to 8b4e651 Compare March 13, 2025 20:35
@afh afh marked this pull request as ready for review March 13, 2025 20:46
@afh afh requested a review from raboof March 13, 2025 20:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5279

@raboof
Copy link
Member

raboof commented Mar 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 384638


x86_64-linux

✅ 2 packages built:
  • icu77
  • icu77.dev

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a good idea to me, should we also make icuReal point to this version?

@raboof raboof requested a review from 7c6f434c March 13, 2025 21:50
@raboof
Copy link
Member

raboof commented Mar 13, 2025

requesting review from @7c6f434c as maintainer of the icu packages

@afh
Copy link
Member Author

afh commented Mar 14, 2025

If folks see benefits in changing the default icu to this new version I propose to do that in a separate PR, given that the effects of this are far greater than just adding a new version that dependant packages can choose to use.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 15, 2025
@7c6f434c 7c6f434c merged commit 9de662f into NixOS:master Mar 22, 2025
40 checks passed
@afh
Copy link
Member Author

afh commented Mar 23, 2025

Thanks for merging 👍

@afh afh deleted the init-icu77-rc1 branch May 18, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants