melonloader-installer: init at 4.2.1#384656
melonloader-installer: init at 4.2.1#384656WillemToorenburgh wants to merge 5 commits intoNixOS:masterfrom
Conversation
85d60c2 to
c4fa4a3
Compare
c4fa4a3 to
e7b9fda
Compare
There was a problem hiding this comment.
Shoot. I'll see if I can find a reference implementation
3fccf5b to
1863978
Compare
|
Realized users will have a hard time running the program if there's no |
|
Seems like this is not a backport, so you will need to target the master branch, not release-24.11. You will need to rebase your PR and change the base branch. |
1863978 to
3bdd789
Compare
|
Well shoot. Thanks for the guidance, @wolfgangwalther. I've done my best to properly rebase the branch to |
|
I'm not sure why ofborg labelled with merge conflict... perhaps it got triggered by the force push and ran before I changed the target branch? 🤔 |
|
Thanks for removing the conflict label! I confess I'm not sure what's up with the cherry-pick checker or why it has failed, but I can't imagine it would be indicative of a problem with this new PR... Right? |
|
@nyukuru I honestly forgot about this PR! It stalled out with not getting any eyes from reviewers with commit permission, and I wasn't sure how to get it more attention. It'll need to be rebased and I'll have to make sure everything still works, but honestly, I don't see why it wouldn't still work. Is this something you'd find useful? |
Maybe not directly, but I was looking into packaging melonloader itself now that there seems be support for linux native modding. So in the case that this pr was abandoned I was hoping to offer to take over or otherwise collaborate |
3bdd789 to
dc6697c
Compare
|
@nyukuru your poking my ADHD-having butt on the matter is collaboration, as far as I'm concerned! The PR has been rebased and updated to the latest revision of MelonLoader Installer :D EDIT: could I trouble you to review the PR? The only other approval I got is from someone who has since deleted their account. |
|
nyukuru
left a comment
There was a problem hiding this comment.
Before this is merged I think the auto updating should be patched out, it wouldn't be functional anyway
|
I'm not against removing the update script, though I'd be interested to know why you're recommending it. Have they fallen out of use/favour? |
|
Not the nix update script, the auto updating code of the installer itself (https://github.com/LavaGang/MelonLoader.Installer/blob/4.2.1/MelonLoader.Installer/Updater.cs) |
|
Oh, well spotted! I'm going to try to suss out how that works and how to patch it out. Might stretch goal into a PR for them for a nice solution for turning auto-update off during build time, but first things first. |
|
Patch has been created! I see one of the CI jobs failed, but the failure is suspicious to say the least. I'm having trouble imagining how it could be related to this latest change, and feel inclined to say it's not me? |
|
@nyukuru I think the auto updating has been patched out! |
|
Thank you! I'm now wondering what I need to do in order to retry the failed CI jobs. I could make a trivial change and push, but that'd get rid of your approval. Would a committer/maintainer be able to re-run them? |
https://github.com/LavaGang/MelonLoader.Installer/releases/tag/4.2.1 melonloader-installer: implement feedback from nixfmt melonloader-installer: make platforms a list melonloader-installer: implement feedback from review
…ate Nuget dependencies
melonloader-installer: obey nixfmt
4838de9 to
d02dfd6
Compare
|
Rebased onto master and resolved |
Update, Jan 30th 2026
I've rebased this onto the latest
mastercommit, bumped the minor version and dependencies, and checked again to make sure everything still works. I've also revised the title and this description to match.Hello! This is my first working attempt at packaging something for Nix(OS) after a few false starts. MelonLoader.Installer seemed like a good choice to try, as their team had just added Linux support as of version 4.1.0.
MelonLoader.Installer is a small utility that lets users easily install their chosen version of MelonLoader into Unity Engine games installed on the user's machine. It is capable of auto-detecting games, and was able to do so successfully on my NixOS installation.
The package is about as simple as it gets: a Dotnet program built with almost all the defaults from the Wiki. I set
selfContainedBuild = trueas that is what it seemed like the code wanted. I was able to verify that the program works as expected, successfully installing MelonLoader DLLs into Neon White.As this is a new package, and I developed it on NixOS 25.11, it should be appropriate for backporting, but I'm not sure how to initiate that process just yet.
Output of
nix-instantiate --eval -A lib.trivial.oldestSupportedRelease:2511Also to note: this software is compatible with macOS, but I didn't add support for that in this package as I have no way to test it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.