linuxPackages.xone: 0.3-unstable-2024-04-25 -> 0.3-unstable-2024-12-23; switch to dlundqvist fork, drop patches for newer kernels, add 'fazzi' as maintainer#384828
Merged
JohnRTitor merged 2 commits intoNixOS:masterfrom Mar 25, 2025
fxzzi:xone-dlundqvist
Merged
linuxPackages.xone: 0.3-unstable-2024-04-25 -> 0.3-unstable-2024-12-23; switch to dlundqvist fork, drop patches for newer kernels, add 'fazzi' as maintainer#384828JohnRTitor merged 2 commits intoNixOS:masterfrom fxzzi:xone-dlundqvist
JohnRTitor merged 2 commits intoNixOS:masterfrom
fxzzi:xone-dlundqvist
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
9999years
approved these changes
Feb 26, 2025
Contributor
9999years
left a comment
9999years
left a comment
There was a problem hiding this comment.
LGTM, thanks for this!
wegank
added
the
12.approvals: 1
Member
|
JohnRTitor
reviewed
Mar 25, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Please separate each logical changes to individual commits.
Contributor
Author
Should be resolved by separating the commit where I add myself as a maintainer, and then the rest. Let me know if this works for you. |
JohnRTitor
reviewed
Mar 25, 2025
Member
JohnRTitor
left a comment
JohnRTitor
left a comment
There was a problem hiding this comment.
Nixfmt RFC style commit is very minimal (just one line) change? So you can just merge it with the last one.
Also change that commit's message to linuxPackages.xone: 0.3-unstable-2024-04-25 -> 0.3-unstable-2024-12-23 and explain why are you switching to the fork.
switch to a fork of the original repo from dlundqvist. It already contains commits to fix builds for 6.11+ kernels, and contains other minor changes. This allows us to drop the patches which we were previously applying. The upstream repo from medusalix seems to be abandoned, and the maintainer of said repo hasn't had any communication on the support discord server since March 2024.
Contributor
Author
yeah I have no idea what even happened there and why the line was removed then added again right after. I've corrected it and squashed down to two commits.
sure. lets hope i added the comment to the commit properly haha |
JohnRTitor
changed the title
Member
|
wegank
removed
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we are using upstream https://github.com/medusalix/xone as the source for our xone nixpkg. This has caused a few issues, like the fact that we have to pull in some patches ourselves to make the module successfully build for newer kernels (6.11+).
We should follow what the official xone support server is suggesting, which is to use dlundqvist's fork of the project.
This allows us to remove the patches we were originally applying (they are upstream in this fork), and also puts us on a more up to date path for the package. It is clear that the original repo is no longer being worked on, considering it hasn't had an update in 10 months, the creator's (medusalix) last message on the support server was on 2024/05/13, and the AUR package maintainer (which was previously me when I was running arch), has now moved the base package over to this fork as well. https://aur.archlinux.org/packages/xone-dkms-git
The comment from the new maintainer states:
This fork also contains a few minor changes including additional support for some devices, and some other minor fixes.
Finally, I have also added myself as a maintainer of this package, just in case the driver ever breaks again for a newer kernel release.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.