Skip to content

min-ed-launcher: init at 0.11.3 #386645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Aleksanaa merged 1 commit into from
Apr 21, 2025
Merged

min-ed-launcher: init at 0.11.3 #386645

Aleksanaa merged 1 commit into from
Apr 21, 2025

Conversation

@jiriks74
Copy link
Contributor

@jiriks74 jiriks74 commented Mar 3, 2025

From project's description: Minimal Elite Dangerous Launcher

It's an alternative launcher for the game Elite: Dangerous. It has provides a faster way to get into game and provides more functionality than the official Frontier launcher.

Some of the advantages:

  • Faster load times compared to the official launcher
  • Auto-quit
  • Can lauch (and quit) other programs (for interacting with the game)
  • Can run Steam, Epic and Frontier Store accounts from a single game install
  • Auto-restart

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from 814518c to 50aada3 Compare March 3, 2025 09:00
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 3, 2025
@ethancedwards8
Copy link
Member

ethancedwards8 commented Mar 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

@ToasterUwU
Copy link
Member

ToasterUwU commented Mar 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

❌ 1 package failed to build:
  • min-ed-launcher

@ToasterUwU
Copy link
Member

ToasterUwU commented Mar 25, 2025 

error: hash mismatch in fixed-output derivation '/nix/store/akz8hbghakx9xwpf62ld6h5bavfi2rna-source.drv':
         specified: sha256-ur1stk5dzdf8FgjGFCVEcNgBDdfYl7Iy7OjwabxV9X8=
            got:    sha256-p970rsDyqXBbxo18q/ocNRkBKBq2CwJA3tAfDicrTOE=

ToasterUwU
ToasterUwU suggested changes Mar 25, 2025
View reviewed changes
Copy link
Member

@ToasterUwU ToasterUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash needs updating. Will test and review again after.

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch 2 times, most recently from b42d8aa to b360f2a Compare March 27, 2025 20:11
@jiriks74 jiriks74 requested a review from ToasterUwU March 27, 2025 20:12
@ToasterUwU
Copy link
Member

ToasterUwU commented Mar 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

@ToasterUwU
Copy link
Member

ToasterUwU commented Mar 27, 2025

It does build now. And it works as well.

Its hard to test for anyone coming after me who wants to test.

So here a little guide:

  1. Install, not use in a shell of any kind (Steam needs to be able to see it in path and start it)
  2. Change the "Launch Options" of the Game on Steam to MinEdLauncher %command% /autorun /autoquit /edo or use /edh if you dont own Odyssey
  3. Start the Game, see if it starts
    (Dont do the bit where you start the launcher in a terminal emulator like the README suggests, its not needed and also didnt really work for me specifically, but thats definetly not an issue with the package or program)

If you dont use Steam for this game check the README in the repo, it explains everything.
If you dont own Elite Dangerous, you cant test this at all.

Since only people who own the Game can properly test this, i want to make very very clear to any potential merger: Im a Maintainer of more than one package in nixpkgs and entirely vouch for the functionality of this program packaged in this way.

ToasterUwU
ToasterUwU suggested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@ToasterUwU ToasterUwU left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor explanation or correction needed, besides that looks really good.

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from b360f2a to aaaed48 Compare March 28, 2025 07:44
@ToasterUwU
Copy link
Member

ToasterUwU commented Mar 28, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

ToasterUwU
ToasterUwU approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@ToasterUwU ToasterUwU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, works normally.

Nix code looks good, comments were added to clarify the need for git.

This is ready to merge!

@nixos-discourse
Copy link

nixos-discourse commented Mar 28, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2326

@ToasterUwU ToasterUwU added 8.has: package (new) This PR adds a new package 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 28, 2025
@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 9, 2025 •
edited
Loading

Any blockers on this one?

I'll bump this PR to v0.11.3.

If the package works are there any other blockers?

@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 9, 2025

Nope, no blockers, we just need a commiter to merge it, so unless you know one and can ask for a look on this, it's the waiting game sadly.

Scrumplex
Scrumplex approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

derivation lgtm. Builds and runs (though I don't have ED)

Could you update this to https://github.com/rfvgyhn/min-ed-launcher/releases/tag/v0.11.3?

Scrumplex
Scrumplex reviewed Apr 14, 2025
View reviewed changes
@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 15, 2025 •
edited
Loading

derivation lgtm. Builds and runs (though I don't have ED)

You can try a dry run. But that's probably not needed as it built and launched.

Could you update this to https://github.com/rfvgyhn/min-ed-launcher/releases/tag/v0.11.3?

I have it on my list since that update came out. Life's had some surprises for me so I haven't been able to do this yet. I should be able to look into it today if something doesn't mess up my schedule.

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from aaaed48 to e9952a7 Compare April 15, 2025 14:18
@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 15, 2025

@Scrumplex Bumped. Builds and runs for me.
@ToasterUwU Could you test the new version as well please?

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from e9952a7 to 9c3d88a Compare April 15, 2025 14:23
@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

❌ 1 package failed to build:
  • min-ed-launcher

@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 15, 2025

error: hash mismatch in fixed-output derivation '/nix/store/lqb7i8lxd7hj48lw0hllf7b59wgly9fr-source.drv':
specified: sha256-s+E7DvM2XpfCz6oIeI/Na5NSxN8gHnzWzABXOrPlwLk=
got: sha256-HJIvbuTsCG51PPVieJbXGyAviqgM9/WPz0+0VhIWz9k=
error: 1 dependencies of derivation '/nix/store/xdzx8928h49ya1j937ilzx8bri401mav-min-ed-launcher-0.11.3.drv' failed to build

@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 15, 2025

Thanks, I'll look into it. Nix probably decided to ignore the version (ref) change and used the old src so I didn't get this error.

@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from 9c3d88a to 850cb4b Compare April 15, 2025 18:51
@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

❌ 1 package failed to build:
  • min-ed-launcher

ToasterUwU
ToasterUwU suggested changes Apr 15, 2025
View reviewed changes
@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch 2 times, most recently from a907bd6 to 44a5b8e Compare April 15, 2025 19:49
@jiriks74
Copy link
Contributor Author

jiriks74 commented Apr 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

1 similar comment
@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

@jiriks74 jiriks74 changed the title min-ed-launcher: init at 0.11.2 min-ed-launcher: init at 0.11.3 Apr 16, 2025
@jiriks74
min-ed-launcher: init at 0.11.3
8c09d46 
- `min-ed-launcher` repository: https://github.com/rfvgyhn/min-ed-launcher

From project's description: Minimal Elite Dangerous Launcher

It's an alternative launcher for the game Elite: Dangerous. It has
provides a faster way to get into game and provides more functionality
than the official Frontier launcher.

Some of the advantages:
- Faster load times compared to the official launcher
- Auto-quit
- Can lauch (and quit) other programs (for interacting with the game)
  - For example EDMarketConnector https://github.com/EDCD/EDMarketConnector
- Can run Steam, Epic and Frontier Store accounts from a single game install
- Auto-restart
@jiriks74 jiriks74 force-pushed the add_min-ed-launcher branch from 44a5b8e to 8c09d46 Compare April 19, 2025 18:41
@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 386645

x86_64-linux

✅ 1 package built:
  • min-ed-launcher

@ToasterUwU
Copy link
Member

ToasterUwU commented Apr 21, 2025

@Scrumplex This has been updated now. Should be ready for merge now!

@Aleksanaa Aleksanaa merged commit a87225b into NixOS:master Apr 21, 2025
26 of 27 checks passed
@jiriks74 jiriks74 deleted the add_min-ed-launcher branch May 26, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

+2 more reviewers

@ethancedwards8 ethancedwards8 ethancedwards8 left review comments

@ToasterUwU ToasterUwU ToasterUwU approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jiriks74 @ethancedwards8 @ToasterUwU @nixos-discourse @Scrumplex @Aleksanaa