perl: filter out reference to apple-sdk package
#386700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysndr
force-pushed
the
perl/reference-to-apple-sdk
branch
from
af38d30 to
a2183db
Compare
ysndr
changed the title
apple-sdk packageapple-sdk package
github-actions
bot
added
10.rebuild-darwin: 5001+
Contributor
|
Best to target the staging branch. |
ysndr
force-pushed
the
perl/reference-to-apple-sdk
branch
from
a2183db to
f998509
Compare
marcusramberg
approved these changes
Mar 18, 2025
wegank
added
12.approvals: 1
wegank
added
the
2.status: merge conflict
ysndr
force-pushed
the
perl/reference-to-apple-sdk
branch
from
f998509 to
f3ebeb1
Compare
ofborg
bot
removed
the
2.status: merge conflict
The perl package started depending on `apple-sdk` via references in
`lib/perl5/5.40.0/darwin-thread-multi-2level/Config_heavy.pl`:
```
fd --type=file . /nix/store/cwlch1mxd40ayx8qy7hl8q2scrwgqhg6-perl-5.40.0/lib/ -X rg "/nix/store/lsjl29pwp5if71jfgxlv8fifsrpax805-apple-sdk-11.3" {}
/nix/store/cwlch1mxd40ayx8qy7hl8q2scrwgqhg6-perl-5.40.0/lib/perl5/5.40.0/darwin-thread-multi-2level/Config_heavy.pl
1039:incpth='/nix/store/j3dhkx4m14m38drh3f40bccrwrgzlsg5-libcxx-19.1.7-dev/include /nix/store/hklang3njvw0f5mgra9vsvn3c2zi2v45-compiler-rt-libc-19.1.7-dev/include /nix/store/g4qcalcnvm5n393xq8p9swxd8rc0xxzj-libxcrypt-4.4.38/include /nix/store/f4z2y0zn2bmrwywp67y3h21cmb6ky547-libiconv-109-dev/include /nix/store/17a9rq4bw8drbhlr3dijrmxzfqlz8z85-libresolv-83-dev/include /nix/store/34bb5prqghfl0hpindhk8xlc5s2q2xjg-libsbuf-14.1.0-dev/include /nix/store/vzi6s9yh1i12bkj9abyfp43y6x1fdzpl-cups-headers-2.4.11/include /no-such-path/resource-root/include /nix/store/lsjl29pwp5if71jfgxlv8fifsrpax805-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include /no-such-path/include'
1087:libpth='/nix/store/g4qcalcnvm5n393xq8p9swxd8rc0xxzj-libxcrypt-4.4.38/lib /no-such-path/resource-root/lib /nix/store/lsjl29pwp5if71jfgxlv8fifsrpax805-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib /no-such-path/lib'
1092:libspath=' /nix/store/g4qcalcnvm5n393xq8p9swxd8rc0xxzj-libxcrypt-4.4.38/lib /no-such-path/resource-root/lib /nix/store/lsjl29pwp5if71jfgxlv8fifsrpax805-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib /no-such-path/lib'
1331:timeincl='/nix/store/lsjl29pwp5if71jfgxlv8fifsrpax805-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/time.h '
```
This change increases the closure size of `perl` from ~115MiB to ~1.11GiB
on darwin systems.
`apple-sdk` seems to be referenced via `stdenv.cc.fallback_sdk`.
Following the exisitng pattern in
`pkgs/development/interpreters/perl/interpreter.nix`,
that removes removes references to `stdenv.cc` and `stdenv.cc.cc`,
this commit also removes the reference to
`apple-sdk` / `stdenv.cc.fallback_sdk`.
ysndr
force-pushed
the
perl/reference-to-apple-sdk
branch
from
f3ebeb1 to
41d3086
Compare
tomberek
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perl package started depending on
apple-sdkvia references inlib/perl5/5.40.0/darwin-thread-multi-2level/Config_heavy.pl:This change increases the closure size of
perlfrom ~115MiB to ~1.11GiB on darwin systems.apple-sdkseems to be referenced viastdenv.cc.fallback_sdk. Following the exisitng pattern inpkgs/development/interpreters/perl/interpreter.nix, that removes removes references tostdenv.ccandstdenv.cc.cc, this commit also removes the reference toapple-sdk/stdenv.cc.fallback_sdk.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.