qwertone: init at 0.5.0 #388974
Merged
qwertone: init at 0.5.0 #388974
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
Aleksanaa
reviewed
Mar 11, 2025
pkgs/by-name/qw/qwertone/package.nix
Outdated
Member
There was a problem hiding this comment.
Suggested change
| description = "Music synthesizer"; | |
| description = "Simple music synthesizer app based on usual qwerty-keyboard for input"; |
ghost
approved these changes
Mar 11, 2025
wegank
added
the
12.approvals: 2
niklaskorz
reviewed
Apr 23, 2025
Comment on lines
+12
to
+20
| rustPlatform.buildRustPackage rec { | ||
| pname = "qwertone"; | ||
| version = "0.5.0"; | ||
|
|
||
| src = fetchFromGitLab { | ||
| domain = "gitlab.com"; | ||
| owner = "azymohliad"; | ||
| repo = "qwertone"; | ||
| tag = "v${version}"; |
Contributor
There was a problem hiding this comment.
Suggested change
| rustPlatform.buildRustPackage rec { | |
| pname = "qwertone"; | |
| version = "0.5.0"; | |
| src = fetchFromGitLab { | |
| domain = "gitlab.com"; | |
| owner = "azymohliad"; | |
| repo = "qwertone"; | |
| tag = "v${version}"; | |
| rustPlatform.buildRustPackage (finalAttrs: { | |
| pname = "qwertone"; | |
| version = "0.5.0"; | |
| src = fetchFromGitLab { | |
| domain = "gitlab.com"; | |
| owner = "azymohliad"; | |
| repo = "qwertone"; | |
| tag = "v${finalAttrs.version}"; |
Contributor
Author
There was a problem hiding this comment.
If this really useful? When overriding the version, the whole src and cargoDeps need to be overrided.
Contributor
There was a problem hiding this comment.
It is considered a best practice as it also removes the need for rec, but I will not block you on it
(especially not blocking because buildRustPackage only recently got the ability to use finalAttrs, so there might a treewide PR eventually as many packages still use rec for the version)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.