nexusmods-app: 0.7.3 -> 0.8.2#388999
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
|
I think I'll remove the passthru tests. Probably as part of this PR. Due to Nexus-Mods/NexusMods.App#2179, (+ its duplicate), and also Nexus-Mods/NexusMods.App#2840 it is not currently feasible to run any of the app's CLI commands within a sandboxed environment without network access. I think this has gotten worse in recent versions, Nexus-Mods/NexusMods.App#2840 may be new to v0.8 afaict. Currently all these tests do is make the ofborg CI fail. I appreciate the CLI is not the highest priority for a GUI app, and its model of having one main process and the CLI either needing to start that process or attach to it depending on a) what the command needs to do and b) whether a main process is already running is difficult to get right. But hopefully this will improve in future versions. We can always add these tests back again once it is possible to run the CLI commands without network access. It may also be possible to download a pinned version of whatever the app is attempting to download, and copy it into the app's cache before running the tests. But this seems unnecessarily complex. |
183ef2d to
a0f0be0
Compare
|
0.8.2 is released, so I've un-drafted. Incidentally, the update script was failing with a non-zero exit code. IDK if that's related to #388989 or just because nix-shell maintainers/scripts/update.nix --argstr package nexusmods-appI didn't look into it in too much detail, the update script was able to bump the version & hash before exiting and I was able to manually build/run EDIT: in hindsight I was probably running into #389194. |
de0d613 to
4dfc9b2
Compare
These tests currently do not work, due to issues running the app's CLI in a nix build environment: - The CLI always starts or connects to an existing main app process - The main app process requires network access (or cached files) - The main app process (usually?) requires a display
Changelog: https://github.com/Nexus-Mods/NexusMods.App/releases/tag/v0.8.2 Also updated disabled tests.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Bumping StrawberryShake allows us to drop the dependency on .NET 8 runtime. See upstream PR Nexus-Mods/NexusMods.App#2830
|
|
khaneliman
left a comment
There was a problem hiding this comment.
Changes look good and tested functionality.
Also:
allowing us to drop .net 8 runtime and only build with .net 9
InstallsFilesSimple_UsingRartest still existsAt first I thought the newly failing tests should've been covered by
RequiresNetworking, however:Notes for end-users
Tip
When upgrading from version 0.7.0 or newer, it should be safe to upgrade without resetting/uninstalling.
Note
All games except Stardew Valley have been moved behind the "Unsupported Games" flag in Settings. If you were modding Cyberpunk, Baldur's Gate 3 or Mount & Blade II:Bannerlord in a previous release, you will need to enable this option to continue managing your mods.
Caution
When upgrading from a version older than 0.7.0, you will need a fresh start.
If you have configuration leftover from an old version, the updated app will crash.
See upstream's guide on how to uninstall the app.
Resetting tips
You can reset all modded games and wipe your nexusmods-app config using:
If you've run the appimage version from upstream, or a pre-0.6 nixpkgs version, you may also need to remove old desktop entries to avoid other issues:
Caution
Known issues are listed on the changelog, but include:
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.