Skip to content

Comments

python312Packages.tensorboard: 2.18.0 -> 2.19.0#389472

Merged
NickCao merged 2 commits intoNixOS:masterfrom
GaetanLepage:tensorboard
Mar 23, 2025
Merged

python312Packages.tensorboard: 2.18.0 -> 2.19.0#389472
NickCao merged 2 commits intoNixOS:masterfrom
GaetanLepage:tensorboard

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 13, 2025 •
edited
Loading

Things done

Changelog: https://github.com/tensorflow/tensorboard/releases/tag/2.19.0

cc @abbradar

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 13, 2025
@nix-owners nix-owners bot requested a review from abbradar March 13, 2025 10:15
@GaetanLepage GaetanLepage requested a review from NickCao March 15, 2025 14:31
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 22, 2025

@ofborg build python312Packages.torch python313Packages.torch python312Packages.tensorflow

NickCao
NickCao reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of dependencies seems to have deviated from what's recorded in the wheel:

Requires-Dist: absl-py>=0.4
Requires-Dist: grpcio>=1.48.2
Requires-Dist: markdown>=2.6.8
Requires-Dist: numpy>=1.12.0
Requires-Dist: packaging
Requires-Dist: protobuf!=4.24.0,>=3.19.6
Requires-Dist: setuptools>=41.0.0
Requires-Dist: six>1.9
Requires-Dist: tensorboard-data-server<0.8.0,>=0.7.0
Requires-Dist: werkzeug>=1.0.1

@GaetanLepage GaetanLepage force-pushed the tensorboard branch 2 times, most recently from 0cfb9f9 to 3288994 Compare March 22, 2025 00:22
@NickCao
Copy link
Member

NickCao commented Mar 22, 2025 •
edited
Loading

Also the comment about wheel might be outdated, doesn't seem to import wheel anymore.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 22, 2025

@ofborg build python312Packages.torch python313Packages.torch python312Packages.tensorflow

@NickCao

This comment was marked as resolved.

Sign in to view
@nix-owners nix-owners bot requested a review from natsukium March 22, 2025 00:30
NickCao
NickCao reviewed Mar 22, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, need some more testing.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 22, 2025

Waiting for #391992

@GaetanLepage GaetanLepage marked this pull request as draft March 22, 2025 00:57
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 22, 2025 •
edited
Loading

@ofborg build python312Packages.torch python313Packages.torch python312Packages.tensorflow

@GaetanLepage GaetanLepage marked this pull request as ready for review March 22, 2025 22:40
@nix-owners nix-owners bot requested review from teh and tscholak March 22, 2025 22:47
@nix-owners nix-owners bot requested a review from thoughtpolice March 22, 2025 22:47
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389472 --package python312Packages.torchaudio --package python312Packages.torch --package python313Packages.tensorboard --package python313Packages.torch --package python313Packages.torchaudio --package python312Packages.torchvision --package python313Packages.torchvision --package python313Packages.tensorflow --package python312Packages.tensorboard --package python312Packages.tensorflow

x86_64-linux

✅ 24 packages built:
  • python312Packages.tensorboard
  • python312Packages.tensorboard.dist (python312Packages.tensorboard.dist.dist)
  • python312Packages.tensorflow
  • python312Packages.tensorflow.dist (python312Packages.tensorflow.dist.dist)
  • python312Packages.torch
  • python312Packages.torch.cxxdev (python312Packages.torch.cxxdev.cxxdev, python312Packages.torch.cxxdev.dev, python312Packages.torch.cxxdev.dist, python312Packages.torch.cxxdev.lib)
  • python312Packages.torch.dev (python312Packages.torch.dev.cxxdev, python312Packages.torch.dev.dev, python312Packages.torch.dev.dist, python312Packages.torch.dev.lib)
  • python312Packages.torch.dist (python312Packages.torch.dist.cxxdev, python312Packages.torch.dist.dev, python312Packages.torch.dist.dist, python312Packages.torch.dist.lib)
  • python312Packages.torch.lib (python312Packages.torch.lib.cxxdev, python312Packages.torch.lib.dev, python312Packages.torch.lib.dist, python312Packages.torch.lib.lib)
  • python312Packages.torchaudio
  • python312Packages.torchaudio.dist (python312Packages.torchaudio.dist.dist)
  • python312Packages.torchvision
  • python312Packages.torchvision.dist (python312Packages.torchvision.dist.dist)
  • python313Packages.tensorboard
  • python313Packages.tensorboard.dist (python313Packages.tensorboard.dist.dist)
  • python313Packages.torch
  • python313Packages.torch.cxxdev (python313Packages.torch.cxxdev.cxxdev, python313Packages.torch.cxxdev.dev, python313Packages.torch.cxxdev.dist, python313Packages.torch.cxxdev.lib)
  • python313Packages.torch.dev (python313Packages.torch.dev.cxxdev, python313Packages.torch.dev.dev, python313Packages.torch.dev.dist, python313Packages.torch.dev.lib)
  • python313Packages.torch.dist (python313Packages.torch.dist.cxxdev, python313Packages.torch.dist.dev, python313Packages.torch.dist.dist, python313Packages.torch.dist.lib)
  • python313Packages.torch.lib (python313Packages.torch.lib.cxxdev, python313Packages.torch.lib.dev, python313Packages.torch.lib.dist, python313Packages.torch.lib.lib)
  • python313Packages.torchaudio
  • python313Packages.torchaudio.dist (python313Packages.torchaudio.dist.dist)
  • python313Packages.torchvision
  • python313Packages.torchvision.dist (python313Packages.torchvision.dist.dist)

aarch64-linux

✅ 24 packages built:
  • python312Packages.tensorboard
  • python312Packages.tensorboard.dist (python312Packages.tensorboard.dist.dist)
  • python312Packages.tensorflow
  • python312Packages.tensorflow.dist (python312Packages.tensorflow.dist.dist)
  • python312Packages.torch
  • python312Packages.torch.cxxdev (python312Packages.torch.cxxdev.cxxdev, python312Packages.torch.cxxdev.dev, python312Packages.torch.cxxdev.dist, python312Packages.torch.cxxdev.lib)
  • python312Packages.torch.dev (python312Packages.torch.dev.cxxdev, python312Packages.torch.dev.dev, python312Packages.torch.dev.dist, python312Packages.torch.dev.lib)
  • python312Packages.torch.dist (python312Packages.torch.dist.cxxdev, python312Packages.torch.dist.dev, python312Packages.torch.dist.dist, python312Packages.torch.dist.lib)
  • python312Packages.torch.lib (python312Packages.torch.lib.cxxdev, python312Packages.torch.lib.dev, python312Packages.torch.lib.dist, python312Packages.torch.lib.lib)
  • python312Packages.torchaudio
  • python312Packages.torchaudio.dist (python312Packages.torchaudio.dist.dist)
  • python312Packages.torchvision
  • python312Packages.torchvision.dist (python312Packages.torchvision.dist.dist)
  • python313Packages.tensorboard
  • python313Packages.tensorboard.dist (python313Packages.tensorboard.dist.dist)
  • python313Packages.torch
  • python313Packages.torch.cxxdev (python313Packages.torch.cxxdev.cxxdev, python313Packages.torch.cxxdev.dev, python313Packages.torch.cxxdev.dist, python313Packages.torch.cxxdev.lib)
  • python313Packages.torch.dev (python313Packages.torch.dev.cxxdev, python313Packages.torch.dev.dev, python313Packages.torch.dev.dist, python313Packages.torch.dev.lib)
  • python313Packages.torch.dist (python313Packages.torch.dist.cxxdev, python313Packages.torch.dist.dev, python313Packages.torch.dist.dist, python313Packages.torch.dist.lib)
  • python313Packages.torch.lib (python313Packages.torch.lib.cxxdev, python313Packages.torch.lib.dev, python313Packages.torch.lib.dist, python313Packages.torch.lib.lib)
  • python313Packages.torchaudio
  • python313Packages.torchaudio.dist (python313Packages.torchaudio.dist.dist)
  • python313Packages.torchvision
  • python313Packages.torchvision.dist (python313Packages.torchvision.dist.dist)

x86_64-darwin

✅ 18 packages built:
  • python312Packages.tensorboard
  • python312Packages.tensorboard.dist (python312Packages.tensorboard.dist.dist)
  • python312Packages.torch
  • python312Packages.torch.cxxdev (python312Packages.torch.cxxdev.cxxdev, python312Packages.torch.cxxdev.dev, python312Packages.torch.cxxdev.dist, python312Packages.torch.cxxdev.lib)
  • python312Packages.torch.dev (python312Packages.torch.dev.cxxdev, python312Packages.torch.dev.dev, python312Packages.torch.dev.dist, python312Packages.torch.dev.lib)
  • python312Packages.torch.dist (python312Packages.torch.dist.cxxdev, python312Packages.torch.dist.dev, python312Packages.torch.dist.dist, python312Packages.torch.dist.lib)
  • python312Packages.torch.lib (python312Packages.torch.lib.cxxdev, python312Packages.torch.lib.dev, python312Packages.torch.lib.dist, python312Packages.torch.lib.lib)
  • python312Packages.torchvision
  • python312Packages.torchvision.dist (python312Packages.torchvision.dist.dist)
  • python313Packages.tensorboard
  • python313Packages.tensorboard.dist (python313Packages.tensorboard.dist.dist)
  • python313Packages.torch
  • python313Packages.torch.cxxdev (python313Packages.torch.cxxdev.cxxdev, python313Packages.torch.cxxdev.dev, python313Packages.torch.cxxdev.dist, python313Packages.torch.cxxdev.lib)
  • python313Packages.torch.dev (python313Packages.torch.dev.cxxdev, python313Packages.torch.dev.dev, python313Packages.torch.dev.dist, python313Packages.torch.dev.lib)
  • python313Packages.torch.dist (python313Packages.torch.dist.cxxdev, python313Packages.torch.dist.dev, python313Packages.torch.dist.dist, python313Packages.torch.dist.lib)
  • python313Packages.torch.lib (python313Packages.torch.lib.cxxdev, python313Packages.torch.lib.dev, python313Packages.torch.lib.dist, python313Packages.torch.lib.lib)
  • python313Packages.torchvision
  • python313Packages.torchvision.dist (python313Packages.torchvision.dist.dist)

aarch64-darwin

✅ 24 packages built:
  • python312Packages.tensorboard
  • python312Packages.tensorboard.dist (python312Packages.tensorboard.dist.dist)
  • python312Packages.tensorflow
  • python312Packages.tensorflow.dist (python312Packages.tensorflow.dist.dist)
  • python312Packages.torch
  • python312Packages.torch.cxxdev (python312Packages.torch.cxxdev.cxxdev, python312Packages.torch.cxxdev.dev, python312Packages.torch.cxxdev.dist, python312Packages.torch.cxxdev.lib)
  • python312Packages.torch.dev (python312Packages.torch.dev.cxxdev, python312Packages.torch.dev.dev, python312Packages.torch.dev.dist, python312Packages.torch.dev.lib)
  • python312Packages.torch.dist (python312Packages.torch.dist.cxxdev, python312Packages.torch.dist.dev, python312Packages.torch.dist.dist, python312Packages.torch.dist.lib)
  • python312Packages.torch.lib (python312Packages.torch.lib.cxxdev, python312Packages.torch.lib.dev, python312Packages.torch.lib.dist, python312Packages.torch.lib.lib)
  • python312Packages.torchaudio
  • python312Packages.torchaudio.dist (python312Packages.torchaudio.dist.dist)
  • python312Packages.torchvision
  • python312Packages.torchvision.dist (python312Packages.torchvision.dist.dist)
  • python313Packages.tensorboard
  • python313Packages.tensorboard.dist (python313Packages.tensorboard.dist.dist)
  • python313Packages.torch
  • python313Packages.torch.cxxdev (python313Packages.torch.cxxdev.cxxdev, python313Packages.torch.cxxdev.dev, python313Packages.torch.cxxdev.dist, python313Packages.torch.cxxdev.lib)
  • python313Packages.torch.dev (python313Packages.torch.dev.cxxdev, python313Packages.torch.dev.dev, python313Packages.torch.dev.dist, python313Packages.torch.dev.lib)
  • python313Packages.torch.dist (python313Packages.torch.dist.cxxdev, python313Packages.torch.dist.dev, python313Packages.torch.dist.dist, python313Packages.torch.dist.lib)
  • python313Packages.torch.lib (python313Packages.torch.lib.cxxdev, python313Packages.torch.lib.dev, python313Packages.torch.lib.dist, python313Packages.torch.lib.lib)
  • python313Packages.torchaudio
  • python313Packages.torchaudio.dist (python313Packages.torchaudio.dist.dist)
  • python313Packages.torchvision
  • python313Packages.torchvision.dist (python313Packages.torchvision.dist.dist)

@NickCao NickCao merged commit 89751d3 into NixOS:master Mar 23, 2025
38 of 39 checks passed
@GaetanLepage GaetanLepage deleted the tensorboard branch March 23, 2025 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@natsukium natsukium Awaiting requested review from natsukium

@teh teh Awaiting requested review from teh

@tscholak tscholak Awaiting requested review from tscholak

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @NickCao