Skip to content

Comments

magic-wormhole: 0.17.0 -> 0.18.0#389591

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
mjoerg:magic-wormhole-0.18.0
Mar 20, 2025
Merged

magic-wormhole: 0.17.0 -> 0.18.0#389591
GaetanLepage merged 1 commit intoNixOS:masterfrom
mjoerg:magic-wormhole-0.18.0

Conversation

@mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Mar 13, 2025

Description of changes

https://github.com/magic-wormhole/magic-wormhole/blob/refs/tags/0.18.0/NEWS.md
magic-wormhole/magic-wormhole@refs/tags/0.17.0...refs/tags/0.18.0

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python313Packages.magic-wormhole
  • python313Packages.magic-wormhole.dist
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 13, 2025
Copy link
Member

@amadaluzia amadaluzia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, builds fine seemingly

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389591


x86_64-linux

✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python313Packages.magic-wormhole
  • python313Packages.magic-wormhole.dist
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info

aarch64-linux

✅ 10 packages built:
  • gnome-keysign
  • gnome-keysign.dist
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python313Packages.magic-wormhole
  • python313Packages.magic-wormhole.dist
  • tahoe-lafs
  • tahoe-lafs.dist
  • tahoe-lafs.doc
  • tahoe-lafs.info

x86_64-darwin

✅ 4 packages built:
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python313Packages.magic-wormhole
  • python313Packages.magic-wormhole.dist

aarch64-darwin

✅ 4 packages built:
  • magic-wormhole (python312Packages.magic-wormhole)
  • magic-wormhole.dist (python312Packages.magic-wormhole.dist)
  • python313Packages.magic-wormhole
  • python313Packages.magic-wormhole.dist

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GaetanLepage GaetanLepage merged commit f578cc0 into NixOS:master Mar 20, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants