Skip to content

Comments

nixos/xpad-noone: init#389752

Merged
misuzu merged 2 commits intoNixOS:masterfrom
Cryolitia-Forks:xpad-noone
Mar 25, 2025
Merged

nixos/xpad-noone: init#389752
misuzu merged 2 commits intoNixOS:masterfrom
Cryolitia-Forks:xpad-noone

Conversation

@Cryolitia
Copy link
Member

@Cryolitia Cryolitia commented Mar 14, 2025

Introduce xpad-noone: https://github.com/medusalix/xpad-noone

While enabling hardware.xone, the default driver xpad will be disabled to prevent conflict, but xone only provides the driver of Xbox One controller but not Xbox 360 controller. The xpad-noone drives only Xbox 360 controller, so can be used safety with xone.

The idea is previously mentioned in #161008 (comment) by @hpfr

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: hardware Drivers, Firmware and Kernels labels Mar 14, 2025
@Cryolitia Cryolitia changed the title Xpad noone xpad-noone: init Mar 14, 2025
@Cryolitia Cryolitia requested a review from Aleksanaa March 14, 2025 07:45
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 14, 2025
@Cryolitia Cryolitia added 8.has: module (new) This PR adds a module in `nixos/` 8.has: package (new) This PR adds a new package labels Mar 14, 2025
@misuzu misuzu changed the title xpad-noone: init nixos/xpad-noone: init Mar 15, 2025
@github-actions github-actions bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation labels Mar 16, 2025
@misuzu
Copy link
Contributor

misuzu commented Mar 16, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389752


x86_64-linux

⏩ 6 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_10.xpad-noone
  • linuxKernel.packages.linux_5_10_hardened.xpad-noone
  • linuxKernel.packages.linux_5_4.xpad-noone
  • linuxKernel.packages.linux_5_4_hardened.xpad-noone
  • linuxPackages_5_10_hardened.xpad-noone
  • linuxPackages_5_4_hardened.xpad-noone
⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 19 packages built:
  • linuxKernel.packages.linux_5_15.xpad-noone
  • linuxPackages_5_15_hardened.xpad-noone (linuxKernel.packages.linux_5_15_hardened.xpad-noone)
  • linuxKernel.packages.linux_6_1.xpad-noone
  • linuxKernel.packages.linux_6_11.xpad-noone
  • linuxPackages_6_11_hardened.xpad-noone (linuxKernel.packages.linux_6_11_hardened.xpad-noone)
  • linuxPackages.xpad-noone (linuxKernel.packages.linux_6_12.xpad-noone)
  • linuxPackages_hardened.xpad-noone (linuxPackages_6_12_hardened.xpad-noone)
  • linuxPackages_latest.xpad-noone (linuxKernel.packages.linux_6_13.xpad-noone)
  • linuxPackages_6_13_hardened.xpad-noone (linuxKernel.packages.linux_6_13_hardened.xpad-noone)
  • linuxPackages_6_1_hardened.xpad-noone (linuxKernel.packages.linux_6_1_hardened.xpad-noone)
  • linuxKernel.packages.linux_6_6.xpad-noone
  • linuxPackages_6_6_hardened.xpad-noone (linuxKernel.packages.linux_6_6_hardened.xpad-noone)
  • linuxPackages_ham.xpad-noone (linuxKernel.packages.linux_ham.xpad-noone)
  • linuxPackages_latest-libre.xpad-noone (linuxKernel.packages.linux_latest_libre.xpad-noone)
  • linuxPackages-libre.xpad-noone (linuxKernel.packages.linux_libre.xpad-noone)
  • linuxPackages_lqx.xpad-noone (linuxKernel.packages.linux_lqx.xpad-noone)
  • linuxPackages_xanmod.xpad-noone (linuxKernel.packages.linux_xanmod.xpad-noone)
  • linuxPackages_xanmod_latest.xpad-noone (linuxKernel.packages.linux_xanmod_latest.xpad-noone, linuxPackages_xanmod_stable.xpad-noone)
  • linuxPackages_zen.xpad-noone (linuxKernel.packages.linux_zen.xpad-noone)

@misuzu misuzu added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 17, 2025
@misuzu misuzu merged commit f630533 into NixOS:master Mar 25, 2025
24 of 27 checks passed
@Cryolitia Cryolitia deleted the xpad-noone branch March 26, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: hardware Drivers, Firmware and Kernels 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants