Skip to content

Comments

electron-{source,bin,chromedriver}: 33.4.3 -> 33.4.5, 34.3.2 -> 34.3.3#389784

Merged
yuyuyureka merged 6 commits intoNixOS:masterfrom
teutat3s:electron-updates
Mar 14, 2025
Merged

electron-{source,bin,chromedriver}: 33.4.3 -> 33.4.5, 34.3.2 -> 34.3.3#389784
yuyuyureka merged 6 commits intoNixOS:masterfrom
teutat3s:electron-updates

Conversation

@teutat3s
Copy link
Member

@teutat3s teutat3s commented Mar 14, 2025

https://github.com/electron/electron/releases/tag/v33.4.4
https://github.com/electron/electron/releases/tag/v33.4.5 (contains security fixes)
https://github.com/electron/electron/releases/tag/v34.3.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@teutat3s teutat3s requested review from TomaSajt and yayayayaka March 14, 2025 11:49
@teutat3s teutat3s added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 labels Mar 14, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Mar 14, 2025
@yuyuyureka yuyuyureka merged commit e8d42eb into NixOS:master Mar 14, 2025
37 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 14, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-389784-to-release-24.11 origin/release-24.11
cd .worktree/backport-389784-to-release-24.11
git switch --create backport-389784-to-release-24.11
git cherry-pick -x d489c31ce3d235b9b5006d0aaef664a0ea407d31 40c39898896e0401cec01b69300373eb086d823d be056cd2e33790ba6d22a772dcedeb30987c7311 259916fe8f23a8a7f362644ae6b97062528b0fe4 34874aaa723612b266e1738af2ef1b1a5b59755c e35e3e2da69306c781fbb78fc64c9154f664c513

@teutat3s teutat3s deleted the electron-updates branch March 15, 2025 06:50
@teutat3s
Copy link
Member Author

I won't be able to take care of the manual backport, no machine around for a few days.

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Mar 15, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-389784-to-release-24.11 origin/release-24.11
cd .worktree/backport-389784-to-release-24.11
git switch --create backport-389784-to-release-24.11
git cherry-pick -x c384a1a10ab0c368de1d8a7b2e62209d1eab44bc 79246b80432a79ecf838eec0446253614e576abe a4575e70640cd8bd85ca2be8ad769a3ef9936dcd 30b8a3e7804fc725b412c84b09db6d046398e223 59f009abe079eac8cddbcc6bac48aabc50692d2d e8d42eb913133c376b6035b67275c69a59010ee6

@yuyuyureka
Copy link
Contributor

#390123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants