Skip to content

Comments

tinygo: 0.35.0 -> 0.36.0#389791

Closed
rvolosatovs wants to merge 1 commit intoNixOS:masterfrom
rvolosatovs:update/tinygo
Closed

tinygo: 0.35.0 -> 0.36.0#389791
rvolosatovs wants to merge 1 commit intoNixOS:masterfrom
rvolosatovs:update/tinygo

Conversation

@rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Mar 14, 2025

Update tinygo to 0.36: https://github.com/tinygo-org/tinygo/releases/tag/v0.36.0

Most importantly, this brings in Go 1.24 support - tinygo package in nixpkgs-unstable is currently broken (and this PR fixes that), due to the 1.24 being the default go.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
@rvolosatovs rvolosatovs marked this pull request as ready for review March 14, 2025 12:19
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 14, 2025
@rvolosatovs rvolosatovs requested review from Madouura and muscaln March 14, 2025 12:20
@muscaln
Copy link
Contributor

muscaln commented Mar 16, 2025

Thanks! Could you remove the llvm version pin from top-level/all-packages.nix? go-llvm bindings now default to version 19. The build fails on linux because of that.

@eliasnaur
Copy link
Contributor

FWIW, v0.37.0 is out with further Go 1.24 support.

@mjmar01 mjmar01 mentioned this pull request Mar 23, 2025
13 tasks
@pbsds
Copy link
Member

pbsds commented Mar 24, 2025

done in #392337

@pbsds pbsds closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants