-
-
Notifications
You must be signed in to change notification settings - Fork 17.5k
moonlight: 1.3.9 -> 1.3.14; moonlight: improved stuff and fixed updating #389945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
isabelroses
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 389945
aarch64-darwin
✅ 1 package built:
- moonlight
|
as of the new ui changes by discord, the moonbase tab in moonlight 1.3.10 no longer works. I suggest skipping ahead and updating the pr for 1.3.11 |
|
insert mercy swooping in gif new version works by just upping da number and changing hashes, tested on a nixpkgs overlay: |
nix-update-scriptnix-update-script
|
Done and Thanks! |
|
I temporarily put this in the
|
nix-update-script|
Works on the nixpkgs commit |
d7b6325 to
bda4e8d
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5374 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2340 |
|
I tried updating moonlight to 1.3.14, but got this error below. It should be offline because the sandboxed nix build normally doesn't have internet access nor could I find a solution to this problem. |
|
Did you update the vendor hash? |
|
Yes, I did. Refreshing the hash did not help. I am gonna push it and mark the PR as draft. |
432fa47 to
eaf50f5
Compare
|
fwiw, this builds absolutely fine for me.
|
|
I guess I should reinstall NixOS |
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Notify Maintainers
@ilyist
@DontEatOreo
Add a 👍 reaction to pull requests you find important.