Skip to content

Conversation

@ilyist
Copy link
Contributor

@ilyist ilyist commented Mar 14, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Notify Maintainers
@ilyist
@DontEatOreo

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 14, 2025
@nix-owners nix-owners bot requested a review from FlameFlag March 14, 2025 21:31
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389945


aarch64-darwin

✅ 1 package built:
  • moonlight

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 21, 2025
@BirbIrl
Copy link

BirbIrl commented Mar 26, 2025

as of the new ui changes by discord, the moonbase tab in moonlight 1.3.10 no longer works. I suggest skipping ahead and updating the pr for 1.3.11

@BirbIrl
Copy link

BirbIrl commented Mar 26, 2025

insert mercy swooping in gif

new version works by just upping da number and changing hashes, tested on a nixpkgs overlay:
version: version = "1.3.11";
git hash: hash = "sha256-lhTv0kAe9qvowcWVt2pxEKLcdVg2HcMYZMvqxWlDx7E=";
pnpm hash: hash = "sha256-FlvWV8SjZLRJ5LzDRtbeVJsy+w+z71NjLysebJo3Ujk=";

@ilyist ilyist changed the title moonlight: 1.3.9 -> 1.3.10; moonlight: (hopefully) fixed nix-update-script moonlight: 1.3.9 -> 1.3.11; moonlight: (hopefully) fixed nix-update-script Mar 26, 2025
@ilyist
Copy link
Contributor Author

ilyist commented Mar 26, 2025

Done and Thanks!

@ilyist ilyist marked this pull request as draft March 27, 2025 16:41
@isabelroses isabelroses removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 27, 2025
@ilyist
Copy link
Contributor Author

ilyist commented Mar 29, 2025

I temporarily put this in the Draft state because I was not fully satisfied with the quality and wanted to do some improvements later. So today I did the following:

  • Pinned meta.changelogs to the release version
  • Entirely patched out the non-extension-related Update UI
  • Shows the actual version and branch instead of dev
  • Updated to pnpm 10
  • Fixed nix-update-script

@ilyist ilyist marked this pull request as ready for review March 29, 2025 19:02
@ilyist ilyist changed the title moonlight: 1.3.9 -> 1.3.11; moonlight: (hopefully) fixed nix-update-script moonlight: 1.3.9 -> 1.3.11; moonlight: improved stuff and fixed updating Mar 29, 2025
@ilyist
Copy link
Contributor Author

ilyist commented Mar 29, 2025

Can anyone test PTB & Canary? Both get stuck at Blackish Screen. Only Stable seems to work.

Works on the nixpkgs commit b629839fff90514c42ef213b86e872cdd3321688

@ilyist ilyist force-pushed the master branch 3 times, most recently from d7b6325 to bda4e8d Compare April 5, 2025 18:44
@ilyist ilyist changed the title moonlight: 1.3.9 -> 1.3.11; moonlight: improved stuff and fixed updating moonlight: 1.3.9 -> 1.3.12; moonlight: improved stuff and fixed updating Apr 9, 2025
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5374

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2340

@ilyist
Copy link
Contributor Author

ilyist commented Apr 16, 2025

I tried updating moonlight to 1.3.14, but got this error below. It should be offline because the sandboxed nix build normally doesn't have internet access nor could I find a solution to this problem.

Configuring pnpm store
 ERROR  GET https://registry.npmjs.org/pnpm: request to https://registry.npmjs.org/pnpm failed, reason: getaddrinfo EAI_AGAIN registry.npmjs.org
For help, run: pnpm help config

logs.txt

@SuperSandro2000
Copy link
Member

Did you update the vendor hash?

@ilyist
Copy link
Contributor Author

ilyist commented Apr 16, 2025

Yes, I did. Refreshing the hash did not help. I am gonna push it and mark the PR as draft.

@ilyist ilyist marked this pull request as draft April 16, 2025 18:05
@ilyist ilyist force-pushed the master branch 3 times, most recently from 432fa47 to eaf50f5 Compare April 16, 2025 18:12
@ilyist ilyist changed the title moonlight: 1.3.9 -> 1.3.12; moonlight: improved stuff and fixed updating moonlight: 1.3.9 -> 1.3.14; moonlight: improved stuff and fixed updating Apr 16, 2025
@keysmashes
Copy link
Contributor

fwiw, this builds absolutely fine for me.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 389945


x86_64-linux

✅ 1 package built:
  • moonlight

@ilyist ilyist marked this pull request as ready for review April 17, 2025 18:56
@ilyist
Copy link
Contributor Author

ilyist commented Apr 17, 2025

I guess I should reinstall NixOS

@SuperSandro2000 SuperSandro2000 merged commit 4b53e30 into NixOS:master Apr 19, 2025
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants