Conversation
|
Technically, you'd have to update the |
|
Yeah, i was a bit suprised to even find that there. |
|
I still am convinced that putting hashes out of the code into a machine readable format is superior to having to mokey-patch Nix expressions with find and replace or static analysis, but as this PR clearly shows most applications have more hashes to pin than just the sources which kind of defeats the point. Attempts to fix this were not fruitful, so I eventually abandoned that idea |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-389960-to-release-24.11 origin/release-24.11
cd .worktree/backport-389960-to-release-24.11
git switch --create backport-389960-to-release-24.11
git cherry-pick -x 7803dc04a1761490eafc995093e1d944bd8f93bd |
1 similar comment
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-389960-to-release-24.11 origin/release-24.11
cd .worktree/backport-389960-to-release-24.11
git switch --create backport-389960-to-release-24.11
git cherry-pick -x 7803dc04a1761490eafc995093e1d944bd8f93bd |
|
Are you sure this fits the backporting guidelines? |
|
It didn't seem like there are any breaking changes in the changelog :O |
|
I bumped the minor version, which according to SemVer allows for breaking changes, because I simply can't guarantee the absence of breaking behavior changes. Especially since this is a CLI application and I am unsure what exactly the version compatibility contract entails. Especially, the CLI parser had a major bump and the order and scope of some flags has changed, which might result in constellations where a command wouldn't run anymore with the update. I'm not strictly against a backport btw, just uncertain as to how strict our policies are |
Changelog: https://github.com/andir/npins/releases/tag/0.3.0
I used the following steps to update npins:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.