angular-language-server: fix collisions#390084
Merged
fpletz merged 1 commit intoNixOS:masterfrom Mar 18, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
tricktron
force-pushed
the
fix-angular-permissions
branch
from
a905290 to
1b1d1a2
Compare
the nixpkgs typescript package in the wrapper instead of the vendored typescript.
tricktron
force-pushed
the
fix-angular-permissions
branch
from
1b1d1a2 to
2e736e2
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5293 |
fpletz
added
the
11.by: package-maintainer
fpletz
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #387400 by using the nixpkgs typescript package in the wrapper instead of the vendored typescript.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.