Skip to content

Comments

isrcsubmit: 2.1.0 -> 2.1.0-unstable-2023-08-10#390246

Merged
pbsds merged 1 commit intoNixOS:masterfrom
antonmosich:isrcsubmit
Mar 23, 2025
Merged

isrcsubmit: 2.1.0 -> 2.1.0-unstable-2023-08-10#390246
pbsds merged 1 commit intoNixOS:masterfrom
antonmosich:isrcsubmit

Conversation

@antonmosich
Copy link
Contributor

This fixes the long-broken build and adds the keyring python library, which is an optional dependency for isrcsubmit to not have to enter the musicbrainz password every time.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 15, 2025
@antonmosich
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390246


x86_64-linux

✅ 2 packages built:
  • isrcsubmit
  • isrcsubmit.dist

This fixes the long-broken build and adds the keyring python library,
which is an optional dependency for isrcsubmit to not have to enter the
musicbrainz password every time.
@pbsbot
Copy link

pbsbot commented Mar 23, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 390246


x86_64-linux

✅ 2 packages built:
  • isrcsubmit
  • isrcsubmit.dist

@pbsds pbsds merged commit a1293da into NixOS:master Mar 23, 2025
27 checks passed
@antonmosich antonmosich deleted the isrcsubmit branch April 18, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants