Skip to content

Comments

piday25: init at 0-unstable-2025-03-13#390353

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Defelo:piday25
Mar 23, 2025
Merged

piday25: init at 0-unstable-2025-03-13#390353
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Defelo:piday25

Conversation

@Defelo
Copy link
Member

@Defelo Defelo commented Mar 16, 2025

https://github.com/elkasztano/piday25

Resolves #390317

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 16, 2025
@Defelo
Copy link
Member Author

Defelo commented Mar 16, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 390353

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/13882608279

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-390353-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/sjfhfzircgdpl48avz6kkbcxy5yl3v2h-piday25-0-unstable-2025-03-13
  • aarch64-linux
    nix-store -r --add-root nixpkgs-pr-390353-aarch64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/i8hj6nynxkznp679bzwg0hf21kfvsj9p-piday25-0-unstable-2025-03-13
  • x86_64-darwin
    nix-store -r --add-root nixpkgs-pr-390353-x86_64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/6sswmsvqx7s5j09j4qm9v2d555k6iagx-piday25-0-unstable-2025-03-13
  • aarch64-darwin
    nix-store -r --add-root nixpkgs-pr-390353-aarch64-darwin \
      --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
      ' \
      /nix/store/s9rk213s3y601r77kb6f4k8hncccw6x6-piday25-0-unstable-2025-03-13

x86_64-linux

✅ 1 package built:
  • piday25

aarch64-linux

✅ 1 package built:
  • piday25

x86_64-darwin

✅ 1 package built:
  • piday25

aarch64-darwin

✅ 1 package built:
  • piday25

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat package

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 16, 2025
@yzhou216
Copy link
Contributor

Thanks for the PR, this works great!

@0xda157 0xda157 added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 23, 2025
@SuperSandro2000 SuperSandro2000 merged commit e03fee5 into NixOS:master Mar 23, 2025
31 checks passed
@Defelo Defelo deleted the piday25 branch March 23, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package request: Piday25

6 participants