nixos/cgit: use alias option for assets#390448
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Aug 1, 2025
Merged
Conversation
github-actions
bot
added
6.topic: nixos
sternenseemann
approved these changes
Jul 28, 2025
Member
I'd say no on both. |
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
I think |
This makes it easier to replace an asset by just setting the Nginx virtual host's `locations."= robots.txt".alias`. Previously you had to either replace the extraConfig with mkForce or clear it and use the `alias` option.
axelkar
force-pushed
the
cgit-robots-alias
branch
from
79c39ed to
d634694
Compare
Member
|
@ofborg test cgit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to replace an asset by just setting the Nginx virtual host's
locations."= robots.txt".alias. Previously you had to either replace the extraConfig with mkForce or clear it and use thealiasoption.Does this need a release notes entry? Should they be set with mkDefault?
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.