Skip to content

Comments

python312Packages.nbdime: modernize, skip failing test on darwin#391012

Merged
happysalada merged 3 commits intoNixOS:masterfrom
GaetanLepage:nbdime
Mar 19, 2025
Merged

python312Packages.nbdime: modernize, skip failing test on darwin#391012
happysalada merged 3 commits intoNixOS:masterfrom
GaetanLepage:nbdime

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 18, 2025

Things done

  • python312Packages.nbdime: modernize, fix failing tests on darwin
  • python312Packages.nbdime: skip failing test on darwin

cc @tbenst

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 18, 2025
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2025
@nix-owners nix-owners bot requested a review from tbenst March 18, 2025 16:41
@GaetanLepage

This comment was marked as outdated.

@happysalada
Copy link
Contributor

The darwin python 3.13 builds appear to be failing, is it anything we can do something about ?

@nix-owners nix-owners bot requested a review from dotlambda March 18, 2025 22:43
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391012


x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.spsdk
  • python312Packages.spsdk.dist
  • python313Packages.spsdk
  • python313Packages.spsdk.dist
✅ 12 packages built:
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-git.dist
  • python312Packages.nbdime
  • python312Packages.nbdime.dist
  • python312Packages.pytest-notebook
  • python312Packages.pytest-notebook.dist
  • python313Packages.jupyterlab-git
  • python313Packages.jupyterlab-git.dist
  • python313Packages.nbdime
  • python313Packages.nbdime.dist
  • python313Packages.pytest-notebook
  • python313Packages.pytest-notebook.dist

aarch64-linux

✅ 12 packages built:
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-git.dist
  • python312Packages.nbdime
  • python312Packages.nbdime.dist
  • python312Packages.pytest-notebook
  • python312Packages.pytest-notebook.dist
  • python313Packages.jupyterlab-git
  • python313Packages.jupyterlab-git.dist
  • python313Packages.nbdime
  • python313Packages.nbdime.dist
  • python313Packages.pytest-notebook
  • python313Packages.pytest-notebook.dist

x86_64-darwin

✅ 12 packages built:
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-git.dist
  • python312Packages.nbdime
  • python312Packages.nbdime.dist
  • python312Packages.pytest-notebook
  • python312Packages.pytest-notebook.dist
  • python313Packages.jupyterlab-git
  • python313Packages.jupyterlab-git.dist
  • python313Packages.nbdime
  • python313Packages.nbdime.dist
  • python313Packages.pytest-notebook
  • python313Packages.pytest-notebook.dist

aarch64-darwin

❌ 4 packages failed to build:
  • python312Packages.spsdk
  • python312Packages.spsdk.dist
  • python313Packages.spsdk
  • python313Packages.spsdk.dist
✅ 12 packages built:
  • python312Packages.jupyterlab-git
  • python312Packages.jupyterlab-git.dist
  • python312Packages.nbdime
  • python312Packages.nbdime.dist
  • python312Packages.pytest-notebook
  • python312Packages.pytest-notebook.dist
  • python313Packages.jupyterlab-git
  • python313Packages.jupyterlab-git.dist
  • python313Packages.nbdime
  • python313Packages.nbdime.dist
  • python313Packages.pytest-notebook
  • python313Packages.pytest-notebook.dist

@GaetanLepage
Copy link
Contributor Author

The darwin python 3.13 builds appear to be failing, is it anything we can do something about ?

Seems to be better now :)

@GaetanLepage GaetanLepage requested a review from kirillrdy March 19, 2025 07:30
@GaetanLepage
Copy link
Contributor Author

Failures are unrelated (click-option-group is broken on master).

@happysalada happysalada merged commit 3821024 into NixOS:master Mar 19, 2025
75 checks passed
@GaetanLepage GaetanLepage deleted the nbdime branch March 19, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants