Skip to content

Comments

metasploit: 6.4.43 -> 6.4.53#391022

Merged
fabaff merged 1 commit intoNixOS:masterfrom
guylamar2006:update-metasploit
Mar 20, 2025
Merged

metasploit: 6.4.43 -> 6.4.53#391022
fabaff merged 1 commit intoNixOS:masterfrom
guylamar2006:update-metasploit

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Mar 18, 2025

Update metasploit to 6.4.53 to keep up with bugfixes and security updates.

  • Update metasploit-framework to version 6.4.53.

    • Incorporates upstream bug fixes, performance improvements, and additional module support.
  • Improve packaging in Nix by:

    • Adjusting nativeBuildInputs to include libffi so that pkg-config finds the proper .pc files.
    • Adding a shellHook in shell.nix to export PKG_CONFIG_PATH and ensure that gem native extensions (such as the one used by the fiddle gem) build correctly.
    • Adding syslog to the Gemfile (using bundle add syslog) to support improved logging.

These changes address build issues (such as Rex::BindFailed errors related to port binding and libffi detection problems) previously encountered in our Nix environment. This update not only makes Metasploit build more reliably in Nix but also brings in the latest security patches and features from upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Format nix scripts with nixfmt 'pkgs/tools/security/metasploit/gemset.nix' 'pkgs/tools/security/metasploit/shell.nix'
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 18, 2025
@nix-owners nix-owners bot requested review from fabaff and makefu March 18, 2025 17:39
@guylamar2006
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391022


x86_64-linux

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 391022

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/13930793173


x86_64-linux

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

aarch64-linux

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

x86_64-darwin

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

aarch64-darwin

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

@fabaff
Copy link
Member

fabaff commented Mar 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391022


x86_64-linux

✅ 4 packages built:
  • armitage
  • metasploit
  • msfpc
  • social-engineer-toolkit

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 00a4190 into NixOS:master Mar 20, 2025
43 checks passed
@guylamar2006 guylamar2006 deleted the update-metasploit branch March 20, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants