[Backport release-24.11] buildVscodeExtension: support finalAttrs through lib.extendMkDerivation#391077
Merged
drupol merged 5 commits intoNixOS:release-24.11from Mar 21, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: vscode
7 tasks
drupol
force-pushed
the
backport-390180-to-release-24.11
branch
2 times, most recently
from
73b3757 to
d6f29b4
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
drupol
force-pushed
the
backport-390180-to-release-24.11
branch
from
d6f29b4 to
38657bc
Compare
(cherry picked from commit 7b47ad2)
Many code in the wild still use `vscode-utils.buildVscodeExtension` with the `name` argument, so it would be better to make it optional. For example, a github code search of `buildVscodeExtension` returns 100+ results, most of them uses the `name` argument: https://github.com/search?q=buildVscodeExtension+language%3ANix&type=code&l=Nix (cherry picked from commit 09801c9)
…ation` (cherry picked from commit f0f9bdd)
…tendMkDerivation` (cherry picked from commit 82d30e0)
(cherry picked from commit 7e022a6)
drupol
force-pushed
the
backport-390180-to-release-24.11
branch
from
38657bc to
0ba0e05
Compare
drupol
changed the title
finalAttrs through lib.extendMkDerivation
Contributor
Author
|
@ofborg build vscode-extensions.myriad-dreamin.tinymist |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.