nixos/initrd: add extraFirmwarePaths option#391166
Merged
ElvishJerricco merged 1 commit intoNixOS:masterfrom Mar 19, 2025
Merged
nixos/initrd: add extraFirmwarePaths option#391166ElvishJerricco merged 1 commit intoNixOS:masterfrom
ElvishJerricco merged 1 commit intoNixOS:masterfrom
Conversation
(cherry picked from commit 488d4316b9e1510c9b4a2eeb8d7e2cc66839a1fc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms don't specify firmware needed by kernel drivers in the driver code itself (i.e. query-able with modinfo). Platforms that use devicetree often specify firmware in the devicetree itself (to see what boards do this from a linux source tree, run
grep -r 'firmware-name =' arch/*/boot/dts). Since our existing initrd builder cannot auto-detect all firmware to include in this case outlined above, we should provide a way to specify extra firmware files to include in the initrd.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.