Skip to content

Comments

nixos/zeronsd: fix acl permissions#391231

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
ferrine:zeronsd-acl
May 26, 2025
Merged

nixos/zeronsd: fix acl permissions#391231
Aleksanaa merged 1 commit intoNixOS:masterfrom
ferrine:zeronsd-acl

Conversation

@ferrine
Copy link
Contributor

@ferrine ferrine commented Mar 19, 2025

Things done

Resolves #402359

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 19, 2025
@ferrine
Copy link
Contributor Author

ferrine commented Mar 25, 2025

Hi, @natsukium, can you please suggest who is the best to review this?

@ferrine
Copy link
Contributor Author

ferrine commented May 16, 2025

hi, @dstengele, could you please have a look?

@dstengele dstengele self-requested a review May 17, 2025 11:36
Copy link
Member

@dstengele dstengele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read up on the mask parameter for ACLs, but according to the docs this should fix the issue. LGTM.
I have to say though that I don't actively use Zerotier anymore since I switched to Tailscale.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 17, 2025
@Aleksanaa Aleksanaa merged commit f974b3e into NixOS:master May 26, 2025
45 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 26, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nixos/zeronsd: acl permissions, missing mask

4 participants