Skip to content

Comments

nushellPlugins.highlight: 1.4.3+0.102.0 -> 1.4.4+0.103.0#391321

Merged
wegank merged 1 commit intoNixOS:masterfrom
MisileLab:nushell
Mar 22, 2025
Merged

nushellPlugins.highlight: 1.4.3+0.102.0 -> 1.4.4+0.103.0#391321
wegank merged 1 commit intoNixOS:masterfrom
MisileLab:nushell

Conversation

@MisileLab
Copy link
Contributor

https://github.com/cptpiepmatz/nu-plugin-highlight/releases/tag/v1.4.4%2B0.103.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 19, 2025
@nix-owners nix-owners bot requested a review from mgttlinger March 19, 2025 17:12
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391321


x86_64-linux

✅ 1 package built:
  • nushellPlugins.highlight

aarch64-linux

✅ 1 package built:
  • nushellPlugins.highlight

Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The upstream change is limited to dependency updates: cptpiepmatz/nu-plugin-highlight@v1.4.3+0.102.0...v1.4.4+0.103.0

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 20, 2025
Copy link
Member

@mgttlinger mgttlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 21, 2025
@wegank wegank merged commit 8cccd03 into NixOS:master Mar 22, 2025
30 checks passed
@MisileLab MisileLab deleted the nushell branch March 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants