Skip to content

python3Packages.watchdog: fix build #391331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oxij wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

python3Packages.watchdog: fix build #391331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d78be22
python3Packages.watchdog: fix build by disabling a test
oxij Mar 19, 2025
8a1adc8
python3Packages.watchdog: re-enable the test, raise `ulimit -n` instead
oxij Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkgs/development/python-modules/watchdog/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@ buildPythonPackage rec {
--replace "--cov-report=term-missing" ""
'';

# otherwise "tests/test_inotify_c.py::test_select_fd"
# fails with "OSError: [Errno 24] Too many open files"
preCheck = ''
ulimit -n 4096
Copy link
Member

@FliegendeWurst FliegendeWurst Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the other tests open at most 2048 files?

Copy link
Member Author

@oxij oxij Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's actually a bit more than 2048, since pytest itself opens files too, but yes, it's the only test that opens that many files, AFAICS.

'';

pytestFlagsArray =
[
"--deselect=tests/test_emitter.py::test_create_wrong_encoding"
Expand All @@ -61,7 +67,7 @@ buildPythonPackage rec {
# segfaults
"--deselect=tests/test_delayed_queue.py::test_delayed_get"
"--deselect=tests/test_emitter.py::test_delete"
# AttributeError: '_thread.RLock' object has no attribute 'key'"
# AttributeError: '_thread.RLock' object has no attribute 'key'
"--deselect=tests/test_skip_repeats_queue.py::test_eventlet_monkey_patching"
]
++ lib.optionals (stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64) [
Expand Down