Skip to content

Comments

bluespec: Install showrules#391335

Merged
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:bluespecshowurles
Mar 20, 2025
Merged

bluespec: Install showrules#391335
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:bluespecshowurles

Conversation

@Artturin
Copy link
Member

I don't know why this was missing but it's probably best to install all the install-extra.

https://www.github.com/B-Lang-org/bsc/blob/65e3a87a17f6b9cf38cbb7b6ad7a4473f025c098/src/comp/Makefile#L359

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

I don't know why this was missing but it's probably best to install all
the `install-extra`.

https://www.github.com/B-Lang-org/bsc/blob/65e3a87a17f6b9cf38cbb7b6ad7a4473f025c098/src/comp/Makefile#L359
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 19, 2025
@nix-owners nix-owners bot requested review from jcumming and thoughtpolice March 19, 2025 17:51
@ThePerfectComputer
Copy link

Second this! These tools help with debugging emitted schedules, converting from bluespec classic/haskell to bluespec verilog, and vice versa.

@Artturin Artturin marked this pull request as draft March 20, 2025 02:06
@Artturin Artturin marked this pull request as ready for review March 20, 2025 02:08
@Artturin
Copy link
Member Author

Artturin commented Mar 20, 2025

I'll fix smoke-test on darwin (needs cctools strip instead of llvm-strip) and try to fix test-suite on both in a new PR

Built both darwin's on the community box

@Artturin Artturin merged commit cac23dd into NixOS:master Mar 20, 2025
37 of 39 checks passed
@Artturin Artturin deleted the bluespecshowurles branch March 20, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants