Skip to content

Comments

keepassxc: symlink CLI programs to bin output on Darwin#391340

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
folliehiyuki:keepassxc-cli-macos
Apr 14, 2025
Merged

keepassxc: symlink CLI programs to bin output on Darwin#391340
GaetanLepage merged 1 commit intoNixOS:masterfrom
folliehiyuki:keepassxc-cli-macos

Conversation

@folliehiyuki
Copy link
Contributor

Fixes #359061.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@folliehiyuki folliehiyuki changed the title keepassxc: symlink CLI programs to bin output keepassxc: symlink CLI programs to bin output on Darwin Mar 19, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 19, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 19, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391340


x86_64-linux

✅ 1 package built:
  • keepassxc

aarch64-linux

✅ 1 package built:
  • keepassxc

x86_64-darwin

❌ 1 package failed to build:
  • keepassxc

aarch64-darwin

❌ 1 package failed to build:
  • keepassxc

@GaetanLepage
Copy link
Contributor

Darwin fails with:

********* Start testing of TestDatabase *********
Config: Using QtTest library 5.15.16, Qt 5.15.16 (arm64-little_endian-lp64 shared (dynamic) release build; by Clang 19.1.7 ), osx 15.3
PASS   : TestDatabase::initTestCase()
PASS   : TestDatabase::testOpen()
PASS   : TestDatabase::testSave()
PASS   : TestDatabase::testSaveAs()
FAIL!  : TestDatabase::testSignals() Compared values are not the same
   Actual   (((spyFileChanged.count()))): 0
   Expected (1)                         : 1
   Loc: [/tmp/nix-build-keepassxc-2.7.10.drv-0/source/tests/TestDatabase.cpp(169)]
PASS   : TestDatabase::testEmptyRecycleBinOnDisabled()
PASS   : TestDatabase::testEmptyRecycleBinOnNotCreated()
PASS   : TestDatabase::testEmptyRecycleBinOnEmpty()
PASS   : TestDatabase::testEmptyRecycleBinWithHierarchicalData()
PASS   : TestDatabase::testCustomIcons()
FAIL!  : TestDatabase::testExternallyModified() Compared values are not the same
   Actual   (((spyFileChanged.count()))): 0
   Expected (1)                         : 1
   Loc: [/tmp/nix-build-keepassxc-2.7.10.drv-0/source/tests/TestDatabase.cpp(288)]
PASS   : TestDatabase::cleanupTestCase()
Totals: 10 passed, 2 failed, 0 skipped, 0 blacklisted, 32680ms
********* Finished testing of TestDatabase *********


97% tests passed, 1 tests failed out of 37

Total Test time (real) =  53.88 sec

The following tests FAILED:
         32 - testdatabase (Failed)
Errors while running CTest
make: *** [Makefile:91: test] Error 8

@folliehiyuki
Copy link
Contributor Author

folliehiyuki commented Apr 12, 2025

The test failure isn't caused by my change, is it? I don't have my local Darwin machine right now, so it'll take a while until I can start debugging the problem, if it's required.

@GaetanLepage
Copy link
Contributor

The test failure isn't caused by my change, is it? I don't have my local Darwin machine right now, so it'll take a while until I can start debugging the problem, if it's required.

No you are right.

@GaetanLepage GaetanLepage merged commit a9c7187 into NixOS:master Apr 14, 2025
27 checks passed
@folliehiyuki folliehiyuki deleted the keepassxc-cli-macos branch October 4, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeepassXC pkg in MacOS does not link binaries

3 participants