linuxPackages.opensnitch-ebpf: remove linux.dev references#391352
linuxPackages.opensnitch-ebpf: remove linux.dev references#391352K900 merged 1 commit intoNixOS:masterfrom
Conversation
|
Is there really no better way to avoid the reference? |
|
If you have any suggestions, I'm open to them. |
|
Well do you know why the reference is there in the first place? |
|
Not really, this is as much as I could tell: |
|
Any thoughts? |
edf4e33 to
14308db
Compare
|
We should really figure out why it's leaking there before we just nukeReferences it and hope for the best. |
|
Okay, and that's just what you said 2 months ago, so how do you propose doing so? I'm not a C programmer, I gave a best effort By the way, I just want to remind that this is a 4000x closure size decrease over a dependency on some header files that I hope you can agree would never make sense to be there at runtime. |
|
Also it's a fairly small codebase: https://github.com/evilsocket/opensnitch/tree/master/ebpf_prog If you know what you're looking for (which I don't) it's probably easy to find. All I noticed were the extra includes in the Makefile which haven't changed in 2 years. |
|
It's just debug info. You can remove it with |
|
Why wouldn't |
14308db to
f18878c
Compare
f18878c to
526fe21
Compare
|
Anyway, review addressed, seems to work. |
|
@K900 any remaining feedback? |
|
Sorry, thought I merged this. |
Fixes #391351 (closure size bloated from 643 KiB to 2.48 GiB)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.