Skip to content

Comments

gh: 2.68.1 -> 2.69.0#391355

Merged
zowoq merged 1 commit intoNixOS:masterfrom
HeitorAugustoLN:bump/gh
Mar 19, 2025
Merged

gh: 2.68.1 -> 2.69.0#391355
zowoq merged 1 commit intoNixOS:masterfrom
HeitorAugustoLN:bump/gh

Conversation

@HeitorAugustoLN
Copy link
Member

@HeitorAugustoLN HeitorAugustoLN commented Mar 19, 2025

Diff: cli/cli@refs/tags/v2.68.1...v2.69.0

Changelog: https://github.com/cli/cli/releases/tag/v2.69.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 19, 2025
@nix-owners nix-owners bot requested a review from zowoq March 19, 2025 18:52
@HeitorAugustoLN
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391355


x86_64-linux

✅ 4 packages built:
  • gh (github-cli)
  • gh-contribs
  • gh-f
  • gh-notify

aarch64-linux

✅ 4 packages built:
  • gh (github-cli)
  • gh-contribs
  • gh-f
  • gh-notify

x86_64-darwin

✅ 4 packages built:
  • gh (github-cli)
  • gh-contribs
  • gh-f
  • gh-notify

aarch64-darwin

✅ 4 packages built:
  • gh (github-cli)
  • gh-contribs
  • gh-f
  • gh-notify

Copy link
Contributor

@Erethon Erethon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and tested on NixOS, LGTM, thanks!

@zowoq zowoq merged commit 8b90097 into NixOS:master Mar 19, 2025
74 of 75 checks passed
@HeitorAugustoLN HeitorAugustoLN deleted the bump/gh branch March 20, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants