Skip to content

Comments

protobuf: 29.3 -> 29.4#391396

Merged
NickCao merged 1 commit intoNixOS:stagingfrom
GaetanLepage:protobuf-29
Mar 19, 2025
Merged

protobuf: 29.3 -> 29.4#391396
NickCao merged 1 commit intoNixOS:stagingfrom
GaetanLepage:protobuf-29

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 19, 2025 •
edited
Loading

Things done

Changelog: https://github.com/protocolbuffers/protobuf/releases/v29.4

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Mar 19, 2025
@nix-owners nix-owners bot requested a review from SuperSandro2000 March 19, 2025 22:41
@GaetanLepage GaetanLepage requested a review from NickCao March 19, 2025 23:50
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Mar 19, 2025

protobuf.tests builds fine on x86_64-linux.

NickCao
NickCao approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff: protocolbuffers/protobuf@v5.29.3...v5.29.4

Basically nop.

@NickCao NickCao merged commit a622225 into NixOS:staging Mar 19, 2025
33 of 35 checks passed
@GaetanLepage GaetanLepage deleted the protobuf-29 branch March 19, 2025 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @NickCao