Open
Conversation
github-actions
bot
added
10.rebuild-darwin: 1
kpcyrd
force-pushed
the
embedded-mono-img
branch
from
7d23849 to
fa7ec42
Compare
Contributor
|
nixpkgs-ci
bot
added
the
9.needs: reviewer
yzhou216
reviewed
Aug 8, 2025
| rustPlatform, | ||
| }: | ||
|
|
||
| rustPlatform.buildRustPackage rec { |
Contributor
There was a problem hiding this comment.
Suggested change
| rustPlatform.buildRustPackage rec { | |
| rustPlatform.buildRustPackage (finalAttrs: { |
yzhou216
reviewed
Aug 8, 2025
| maintainers = with lib.maintainers; [ kpcyrd ]; | ||
| platforms = lib.platforms.all; | ||
| }; | ||
| } |
yzhou216
reviewed
Aug 8, 2025
| src = fetchFromGitHub { | ||
| owner = "kpcyrd"; | ||
| repo = "embedded-mono-img"; | ||
| tag = "v${version}"; |
Contributor
There was a problem hiding this comment.
Suggested change
| tag = "v${version}"; | |
| tag = "v${finalAttrs.version}"; |
yzhou216
reviewed
Aug 8, 2025
| meta = { | ||
| description = "Convert .png images to raw binary for embedded_graphics"; | ||
| homepage = "https://github.com/kpcyrd/embedded-mono-img"; | ||
| changelog = "https://github.com/kpcyrd/embedded-mono-img/releases/tag/v${version}"; |
Contributor
There was a problem hiding this comment.
Suggested change
| changelog = "https://github.com/kpcyrd/embedded-mono-img/releases/tag/v${version}"; | |
| changelog = "https://github.com/kpcyrd/embedded-mono-img/releases/tag/v${finalAttrs.version}"; |
yzhou216
reviewed
Aug 8, 2025
| hash = "sha256-eOW7DMNNmgJYcScfBwowxAJPSJbwAP55ZgqCAftH36U="; | ||
| }; | ||
|
|
||
| useFetchCargoVendor = true; |
Contributor
There was a problem hiding this comment.
Suggested change
| useFetchCargoVendor = true; |
useFetchCargoVendor is non‐optional and enabled by default as of 25.05, remove it
yzhou216
reviewed
Aug 8, 2025
| lib, | ||
| fetchFromGitHub, | ||
| rustPlatform, | ||
| }: |
Contributor
There was a problem hiding this comment.
Suggested change
| }: | |
| versionCheckHook, | |
| nix-update-script, | |
| }: |
yzhou216
reviewed
Aug 8, 2025
|
|
||
| useFetchCargoVendor = true; | ||
| cargoHash = "sha256-6J2x+v52sL1UbggD3dDz7/kIKgfAjiCf4IvD9c6eGYs="; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| doInstallCheck = true; | |
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| passthru.updateScript = nix-update-script { }; | |
yzhou216
reviewed
Aug 8, 2025
|
|
||
| rustPlatform.buildRustPackage rec { | ||
| pname = "embedded-mono-img"; | ||
| version = "0.1.0"; |
nixpkgs-ci
bot
removed
the
9.needs: reviewer
nixpkgs-ci
bot
added
the
2.status: stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.