vpkedit: init at 4.4.2#391455
vpkedit: init at 4.4.2#391455GaetanLepage merged 2 commits intoNixOS:masterfrom RdrSeraphim:add-vpkedit
Conversation
|
Thank you! |
|
Could you squash your commits into one please. |
0xda157
left a comment
There was a problem hiding this comment.
I'm not very familiar with dpkg so someone else should do the rest of the reviewing on this.
GaetanLepage
left a comment
There was a problem hiding this comment.
The produced output does not have a bin/ directory. You may have to investigate some more.
I've been able to get this going, although with all the Qt dependency the result is some subfolders in bin/ for Qt plugins. I'm not sure if that's acceptable for the ideal package structure but this is the only way the program runs, it seems. Should I look into a different solution or is this fine? |
|
Well, we need to have at least the program's main executable in |
|
This leaves this with the build-from-source option then. I'll take a look into their build workflows and see how they piece it together. |
|
I just discovered that #326999 exists, which builds from source. It's behind a couple minor versions but I've made some adjustments to handle the vendored dependencies without cmake trying to fetch repos on its own. |
GaetanLepage
left a comment
There was a problem hiding this comment.
Nice if we can build it from source!
Maybe consider adding
Co-authored-by: HurricanePootis <53066639+HurricanePootis@users.noreply.github.com>
In the commit description to give credits to @HurricanePootis
|
Update now stores translation data in |
|
GaetanLepage
left a comment
There was a problem hiding this comment.
This looks very good!
Can you add a comment detailing how the various *-src should be updated.
For instance a link to the upstream file that references the needed commit hashes.
|
Co-authored-by: HurricanePootis <53066639+HurricanePootis@users.noreply.github.com>
GaetanLepage
left a comment
There was a problem hiding this comment.
All good! Thank you for your patience @SeraphimRP !
I have just force-pushed minor changes so that we could avoid yet another review round.
Good job :)
Adds VPKEdit, a tool to {create,peruse,modify} pack file formats of various game engines.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.