Skip to content

Comments

python3Packages.filecheck: 0.0.24 -> 1.0.1#391568

Closed
AntonLydike wants to merge 0 commit intoNixOS:masterfrom
AntonLydike:master
Closed

python3Packages.filecheck: 0.0.24 -> 1.0.1#391568
AntonLydike wants to merge 0 commit intoNixOS:masterfrom
AntonLydike:master

Conversation

@AntonLydike
Copy link
Contributor

Update the version of the filecheck python package. This package has seen a change in maintainers and project location, as documented here in the old project.

I don't have a ton of experience with packaging for nix, so this is a first attempt and will probably need some revisions. Happy to implement needed changes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 20, 2025
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Mar 20, 2025
@AntonLydike
Copy link
Contributor Author

Pinging @yorickvP as listed package maintainer

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 20, 2025
@nix-owners nix-owners bot requested a review from yorickvP March 20, 2025 13:32
@AntonLydike
Copy link
Contributor Author

(how are all the checks passing if the hash is all zeros?)

@jopejoe1 jopejoe1 added the 11.by: upstream-developer This issue or PR was created by the developer of packaged software. label Mar 20, 2025
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the commit message to python3Packages.filecheck: 0.0.24 -> 1.0.1 to follow commit conventions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tobe changed into a real hash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I go about obtaining such a hash? I seem to remember that "just put an empty string and look for the error message" was the common advice a while back, but this appears to not work anymore?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my local branch of nixpkgs I would generally try to build the package of which I want to get the hash of, and then it would throw an error message with the correct hash.

I generally use nix build for that, e.g. for this package it would be nix build .#python3Packages.filecheck which returns an error message with the correct hash in this case sha256-orOfrXqIT/qgwPtEcuuJSK3fwmdRPjx4LmzTshxNN0I=.

@dotlambda dotlambda changed the title Udpate version of python3Packages.filecheck python3Packages.filecheck: 0.0.24 -> 1.0.1 Mar 30, 2025
@AntonLydike
Copy link
Contributor Author

@jopejoe1 Can you point me at how I can get the right hash for the build script? I was under the assumption that the build would fail with a wrong hash (and then print the expected value), but CI appears to succeed, even with a blank hash. What is the expected way of obtaining such a hash?

@mdaniels5757
Copy link
Member

Can you point me at how I can get the right hash for the build script? I was under the assumption that the build would fail with a wrong hash (and then print the expected value), but CI appears to succeed, even with a blank hash. What is the expected way of obtaining such a hash?

@AntonLydike It looks like the correct hash is sha256-orOfrXqIT/qgwPtEcuuJSK3fwmdRPjx4LmzTshxNN0I= per https://github.com/NixOS/nixpkgs/pull/391568/checks?check_run_id=39728976447. The other way to get this is with nix-prefetch-git, which returns the same hash when run like so: nix-prefetch-git https://github.com/antonlydike/filecheck.git v1.0.1.

@sarahec
Copy link
Contributor

sarahec commented Jun 13, 2025

@jopejoe1 Can you point me at how I can get the right hash for the build script? I was under the assumption that the build would fail with a wrong hash (and then print the expected value), but CI appears to succeed, even with a blank hash. What is the expected way of obtaining such a hash?

  1. Check out the PR's branch
  2. Since this is quite old, rebase atop master before building.
  3. nix-build -A python313Packages.filecheck
  4. The build will fail and print out the source package's hash. Copy and paste this into your derivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: upstream-developer This issue or PR was created by the developer of packaged software. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants