python3Packages.filecheck: 0.0.24 -> 1.0.1#391568
python3Packages.filecheck: 0.0.24 -> 1.0.1#391568AntonLydike wants to merge 0 commit intoNixOS:masterfrom
Conversation
|
Pinging @yorickvP as listed package maintainer |
|
(how are all the checks passing if the hash is all zeros?) |
There was a problem hiding this comment.
This needs tobe changed into a real hash
There was a problem hiding this comment.
How do I go about obtaining such a hash? I seem to remember that "just put an empty string and look for the error message" was the common advice a while back, but this appears to not work anymore?
There was a problem hiding this comment.
In my local branch of nixpkgs I would generally try to build the package of which I want to get the hash of, and then it would throw an error message with the correct hash.
I generally use nix build for that, e.g. for this package it would be nix build .#python3Packages.filecheck which returns an error message with the correct hash in this case sha256-orOfrXqIT/qgwPtEcuuJSK3fwmdRPjx4LmzTshxNN0I=.
|
@jopejoe1 Can you point me at how I can get the right hash for the build script? I was under the assumption that the build would fail with a wrong hash (and then print the expected value), but CI appears to succeed, even with a blank hash. What is the expected way of obtaining such a hash? |
@AntonLydike It looks like the correct hash is |
|
Update the version of the
filecheckpython package. This package has seen a change in maintainers and project location, as documented here in the old project.I don't have a ton of experience with packaging for nix, so this is a first attempt and will probably need some revisions. Happy to implement needed changes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.