Skip to content

Comments

vimPlugins.obsidian-nvim: switch to community fork#391643

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:obsidian-nvim
Mar 20, 2025
Merged

vimPlugins.obsidian-nvim: switch to community fork#391643
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:obsidian-nvim

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Mar 20, 2025

Things done

https://github.com/epwalsh/obsidian.nvim is unmaintained and obsidian.nvim has been forked by the community.
Let's use the maintained repo: https://github.com/obsidian-nvim/obsidian.nvim/

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 391643 --package vimPlugins.obsidian-nvim


x86_64-linux

✅ 1 package built:
  • vimPlugins.obsidian-nvim

aarch64-linux

✅ 1 package built:
  • vimPlugins.obsidian-nvim

x86_64-darwin

✅ 1 package built:
  • vimPlugins.obsidian-nvim

aarch64-darwin

✅ 1 package built:
  • vimPlugins.obsidian-nvim

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 20, 2025
@MattSturgeon
Copy link
Contributor

Some discussion upstream about forking: epwalsh/obsidian.nvim#820

@MattSturgeon MattSturgeon added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 20, 2025
@GaetanLepage GaetanLepage merged commit 527fcd5 into NixOS:master Mar 20, 2025
64 of 68 checks passed
@GaetanLepage GaetanLepage deleted the obsidian-nvim branch March 20, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: vim Advanced text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants