SDL_compat: re-export PKG_CHECK_MODULES macro as a build depend#391687
Merged
K900 merged 1 commit intoNixOS:staging-nextfrom Mar 21, 2025
Merged
SDL_compat: re-export PKG_CHECK_MODULES macro as a build depend#391687K900 merged 1 commit intoNixOS:staging-nextfrom
K900 merged 1 commit intoNixOS:staging-nextfrom
Conversation
Without the change `powermanga` build fails on `staging-next` as https://hydra.nixos.org/build/292745998: ./configure: line 5413: syntax error near unexpected token `SDL,' ./configure: line 5413: ` PKG_CHECK_MODULES(SDL, sdl >= $min_sdl_version,' This happens because `PKG_CHECK_MODULES` definition is missing.
github-actions
bot
added
10.rebuild-darwin: 11-100
13 tasks
Contributor
|
Good find! I saw the failing build but didn't realize this was actually caused by my SDL changes. Thank you for finding and fixing this, appreciated 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change
powermangabuild fails onstaging-nextas https://hydra.nixos.org/build/292745998:This happens because
PKG_CHECK_MODULESdefinition is missing.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.